From: Namjae Jeon <linkinjeon@gmail.com>
To: Girish K S <girish.shivananjappa@linaro.org>
Cc: linux-scsi@vger.kernel.org,
james.bottomley@hansenpartnership.com, vinholikatti@gmail.com,
santoshsy@gmail.com, patches@linaro.org
Subject: Re: [RFC PATCH 0/4] Add support for pci/non-pci probing for UFS
Date: Tue, 15 May 2012 12:32:19 +0900 [thread overview]
Message-ID: <CAKYAXd-B1ejaY_NX+hPwiC9s5yC-0zvsbcAzuVnxNNt6m2UUsQ@mail.gmail.com> (raw)
In-Reply-To: <CAGxe1ZFbkRRuz93v5qfU7Am1N3briUMOxzxFybmv7k79cVp21Q@mail.gmail.com>
2012/5/15, Girish K S <girish.shivananjappa@linaro.org>:
> Sorry ,
> I will rebase them to James' for-next treee. and resend
>
> thanks and regards
> Girish K S
There is one more thing.
You add your module author name.
But module author name should be only one per one module.
Your author name will be comflicted with origianl author(santosh, vinayak).
plz try to check like this. maybe you can see your name instread
original author.
/sbin/modinfo ufshcd.ko
Thanks.
>
> On 15 May 2012 07:08, Namjae Jeon <linkinjeon@gmail.com> wrote:
>> Hi. Girish.
>>
>> There are hunks when I try to patch.
>> have you created patches on linux-next ?
>>
>> patching file drivers/scsi/ufs/ufs.h
>> patching file drivers/scsi/ufs/ufshcd.c
>> Hunk #10 FAILED at 826.
>> Hunk #13 FAILED at 929.
>> Hunk #15 succeeded at 1050 with fuzz 1 (offset 2 lines).
>> Hunk #17 succeeded at 1193 (offset 2 lines).
>> Hunk #19 succeeded at 1392 (offset 2 lines).
>> Hunk #21 succeeded at 1571 (offset 2 lines).
>> Hunk #23 succeeded at 1644 (offset 2 lines).
>> Hunk #25 FAILED at 1724.
>> 3 out of 25 hunks FAILED -- saving rejects to file
>> drivers/scsi/ufs/ufshcd.c.rej
>>
>> And after testing, have you sent this patch ?
>>
>> Thanks.
>>
>> 2012/5/14, Girish K S <girish.shivananjappa@linaro.org>:
>>> The existing UFS driver is tightly bound to only pci specific devices.
>>> It cannot work for non-pci devices.
>>>
>>> "SCSI: UFS: remove all pci code from core driver" patch removes all the
>>> pci specific code from the core driver to make it generic
>>>
>>> "SCSI: UFS: Add support for pci probe" patch adds a new file to support
>>> pci probing.
>>>
>>> "SCSI: UFS: Add platform support for ufs host controller" patch adds a
>>> new
>>> file to support platform device probe
>>>
>>> "SCSI: UFS: Added support of PCI/PLTFM for UFS" patch adds the menu
>>> option
>>> in Kconfig and Makefile to enable/disable the specific option
>>>
>>> Girish K S (4):
>>> SCSI: UFS: remove all pci code from core driver
>>> SCSI: UFS: Add support for pci probe
>>> SCSI: UFS: Add platform support for ufs host controller
>>> SCSI: UFS: Added support of PCI/PLTFM for UFS
>>>
>>> drivers/scsi/ufs/Kconfig | 32 +++-
>>> drivers/scsi/ufs/Makefile | 2 +
>>> drivers/scsi/ufs/ufs.h | 103 +++++++++++
>>> drivers/scsi/ufs/ufshcd-pci.c | 217 ++++++++++++++++++++++
>>> drivers/scsi/ufs/ufshcd-pltfm.c | 191 ++++++++++++++++++++
>>> drivers/scsi/ufs/ufshcd.c | 377
>>> +++++++++------------------------------
>>> 6 files changed, 623 insertions(+), 299 deletions(-)
>>> create mode 100644 drivers/scsi/ufs/ufshcd-pci.c
>>> create mode 100644 drivers/scsi/ufs/ufshcd-pltfm.c
>>>
>>> --
>>> 1.7.4.1
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>
next prev parent reply other threads:[~2012-05-15 3:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 11:08 [RFC PATCH 0/4] Add support for pci/non-pci probing for UFS Girish K S
2012-05-14 11:08 ` [RFC PATCH 1/4] SCSI: UFS: remove all pci code from core driver Girish K S
2012-05-14 11:08 ` [RFC PATCH 2/4] SCSI: UFS: Add support for pci probe Girish K S
2012-05-14 11:08 ` [RFC PATCH 3/4] SCSI: UFS: Add platform support for ufs host controller Girish K S
2012-05-14 11:08 ` [RFC PATCH 4/4] SCSI: UFS: Added support of PCI/PLTFM for UFS Girish K S
2012-05-15 1:38 ` [RFC PATCH 0/4] Add support for pci/non-pci probing " Namjae Jeon
2012-05-15 2:53 ` Girish K S
2012-05-15 3:32 ` Namjae Jeon [this message]
2012-05-15 4:24 ` Girish K S
2012-05-15 4:51 ` Girish K S
2012-05-15 5:29 ` Namjae Jeon
2012-05-15 6:13 ` Girish K S
2012-06-07 4:22 ` vinayak holikatti
2012-06-07 4:51 ` vinayak holikatti
2012-06-07 6:45 ` Girish K S
2012-06-07 14:35 ` vinayak holikatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKYAXd-B1ejaY_NX+hPwiC9s5yC-0zvsbcAzuVnxNNt6m2UUsQ@mail.gmail.com \
--to=linkinjeon@gmail.com \
--cc=girish.shivananjappa@linaro.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=patches@linaro.org \
--cc=santoshsy@gmail.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).