From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roland Dreier Subject: Re: [PATCH 0/2] Fix the qla2xxx loopback selftests Date: Mon, 22 Oct 2012 08:46:22 -0700 Message-ID: References: <502a736f.21d4320a.4e09.44cf@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: Received: from na3sys010aog107.obsmtp.com ([74.125.245.82]:33105 "HELO na3sys010aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1750950Ab2JVPqo (ORCPT ); Mon, 22 Oct 2012 11:46:44 -0400 Received: by mail-qc0-f198.google.com with SMTP id e13so5298966qcs.1 for ; Mon, 22 Oct 2012 08:46:42 -0700 (PDT) In-Reply-To: Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Chad Dupuis Cc: "steve@purestorage.com" , "linux-scsi@vger.kernel.org" , Dept-Eng Linux Driver , Andrew Vasquez , "James E.J. Bottomley" On Tue, Aug 14, 2012 at 2:15 PM, Chad Dupuis wrote: > > > On Tue, 14 Aug 2012, steve@purestorage.com wrote: > >> From: Steve Hodgson >> >> A few months ago our 2.6.39 based kernel started crashing almost 100% >> of the time when running the selftests, after seeminly unrelated kernel >> changes. In the end it was traced down to this use after free. >> >> Whilst here fix an error path memory leak. >> >> Thanks, >> >> Steve >> >> Steve Hodgson (2): >> qla2xxx: Fix use after free in qla2x000_process_loopback. >> qla2xxx: Free rsp_data even on error in qla2x00_process_loopback() >> >> drivers/scsi/qla2xxx/qla_bsg.c | 17 +++++++++-------- >> 1 file changed, 9 insertions(+), 8 deletions(-) >> >> > > Hi Steve, thanks for the patches. We'll look into them and let you know if > there is anything extra needed. Looking at the 3.7-rc code, it looks like the use-after-free is still there. Any plans on merging these patches? - R.