From: Santosh Y <santoshsy@gmail.com>
To: Akinobu Mita <mita@fixstars.com>
Cc: linux-scsi@vger.kernel.org,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH 1/2] [SCSI] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call
Date: Wed, 12 Jun 2013 12:35:28 +0530 [thread overview]
Message-ID: <CALMYJDu+a_jqJ_m6mMKk_5MzYoRtOv2F+U1_TdcTmuMGA687xQ@mail.gmail.com> (raw)
In-Reply-To: <1370776799-12373-1-git-send-email-mita@fixstars.com>
On Sun, Jun 9, 2013 at 4:49 PM, Akinobu Mita <mita@fixstars.com> wrote:
> Changing the device coherent dma mask to the value that currently set
> has no effect.
>
> Signed-off-by: Akinobu Mita <mita@fixstars.com>
> Cc: Vinayak Holikatti <vinholikatti@gmail.com>
> Cc: Santosh Y <santoshsy@gmail.com>
> Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
> Cc: linux-scsi@vger.kernel.org
> ---
> drivers/scsi/ufs/ufshcd-pltfrm.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c
> index 0014e28..969c9bc 100644
> --- a/drivers/scsi/ufs/ufshcd-pltfrm.c
> +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c
> @@ -100,7 +100,6 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev)
> struct resource *irq_res;
> resource_size_t mem_size;
> int err;
> - struct device *dev = &pdev->dev;
>
> mem_res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> if (!mem_res) {
> @@ -132,12 +131,6 @@ static int ufshcd_pltfrm_probe(struct platform_device *pdev)
> goto out_iounmap;
> }
>
> - err = dma_set_coherent_mask(dev, dev->coherent_dma_mask);
> - if (err) {
> - dev_err(&pdev->dev, "set dma mask failed\n");
> - goto out_iounmap;
> - }
> -
> err = ufshcd_init(&pdev->dev, &hba, mmio_base, irq_res->start);
> if (err) {
> dev_err(&pdev->dev, "Intialization failed\n");
> --
> 1.8.1.4
>
Acked-by: Santosh Y <santoshsy@gmail.com>
--
~Santosh
prev parent reply other threads:[~2013-06-12 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 11:19 [PATCH 1/2] [SCSI] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call Akinobu Mita
2013-06-09 11:19 ` [PATCH 2/2] [SCSI] ufs: fix DMA mask setting Akinobu Mita
2013-06-12 7:05 ` Santosh Y
2013-06-12 7:05 ` Santosh Y [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALMYJDu+a_jqJ_m6mMKk_5MzYoRtOv2F+U1_TdcTmuMGA687xQ@mail.gmail.com \
--to=santoshsy@gmail.com \
--cc=JBottomley@parallels.com \
--cc=linux-scsi@vger.kernel.org \
--cc=mita@fixstars.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).