From: Santosh Y <santoshsy@gmail.com>
To: KOBAYASHI Yoshitake <yoshitake.kobayashi@toshiba.co.jp>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, patches@linaro.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
arnd.bergmann@linaro.org, saugata.das@linaro.org,
dsaxena@linaro.org, stephen.doel@linaro.org, venkat@linaro.org,
ilho215.lee@samsung.com, nala.la@samsung.com,
girish.shivananjappa@linaro.org, vishak.g@samsung.com,
k.rajesh@samsung.com, yejin.moon@samsung.com,
sreekumar.c@samsung.com, vinholikatti@gmail.com,
linkinjeon@gmail.com, michaelc@cs.wisc.edu
Subject: Re: [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver
Date: Tue, 27 Mar 2012 09:31:37 +0530 [thread overview]
Message-ID: <CALMYJDu5+=wQSkR9SGMFqOSRARPeSK0XzmG8sfjuj2qUn9jOLA@mail.gmail.com> (raw)
In-Reply-To: <4F6FF179.5090600@toshiba.co.jp>
On Mon, Mar 26, 2012 at 10:02 AM, KOBAYASHI Yoshitake
<yoshitake.kobayashi@toshiba.co.jp> wrote:
>> > + utrdlp[i].response_upiu_length =
>> > + cpu_to_le16(ALIGNED_UPIU_SIZE);
>
>
> Response UPIU Length(RUL) shows the response UPIU length in Dword.
> (JEDEC Standard No.223 6.2.1 UTP Transfer Request Descriptor)
> The following will be correct.
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 07ec973..feffe65 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -836,7 +836,7 @@ static void ufshcd_host_memory_configure(struct ufs_hba
> *hba)
> utrdlp[i].prd_table_offset =
> cpu_to_le16((prdt_offset >> 2));
> utrdlp[i].response_upiu_length =
> - cpu_to_le16(ALIGNED_UPIU_SIZE);
> + cpu_to_le16(ALIGNED_UPIU_SIZE >> 2);
>
>
> hba->lrb[i].utr_descriptor_ptr = (utrdlp + i);
> hba->lrb[i].ucd_cmd_ptr =
>
Thanks, i'll update it.
--
~Santosh
next prev parent reply other threads:[~2012-03-27 4:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 6:41 [PATCH v3 0/5] [SCSI] ufshcd: UFS Host Controller Driver Santosh Y
2012-02-29 6:41 ` [PATCH v3 1/5] [SCSI] ufshcd: UFS Host controller driver Santosh Y
2012-03-26 4:32 ` KOBAYASHI Yoshitake
2012-03-27 4:01 ` Santosh Y [this message]
2012-02-29 6:41 ` [PATCH v3 2/5] [SCSI] ufshcd: UFS UTP Transfer requests handling Santosh Y
2012-03-26 4:34 ` KOBAYASHI Yoshitake
2012-03-27 4:03 ` Santosh Y
2012-03-27 5:52 ` Santosh Y
2012-03-29 1:40 ` KOBAYASHI Yoshitake
2012-04-10 11:08 ` Venkatraman S
2012-02-29 6:41 ` [PATCH v3 3/5] [SCSI] ufshcd: UFSHCI error handling Santosh Y
2012-02-29 6:41 ` [PATCH v3 4/5] [SCSI] ufshcd: SCSI " Santosh Y
2012-02-29 6:41 ` [PATCH v3 5/5] Documentation: UFS Host Controller Driver Santosh Y
2012-03-22 13:51 ` [PATCH v3 0/5] [SCSI] ufshcd: " James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALMYJDu5+=wQSkR9SGMFqOSRARPeSK0XzmG8sfjuj2qUn9jOLA@mail.gmail.com' \
--to=santoshsy@gmail.com \
--cc=James.Bottomley@hansenpartnership.com \
--cc=arnd.bergmann@linaro.org \
--cc=dsaxena@linaro.org \
--cc=girish.shivananjappa@linaro.org \
--cc=ilho215.lee@samsung.com \
--cc=k.rajesh@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=michaelc@cs.wisc.edu \
--cc=nala.la@samsung.com \
--cc=patches@linaro.org \
--cc=saugata.das@linaro.org \
--cc=sreekumar.c@samsung.com \
--cc=stephen.doel@linaro.org \
--cc=venkat@linaro.org \
--cc=vinholikatti@gmail.com \
--cc=vishak.g@samsung.com \
--cc=yejin.moon@samsung.com \
--cc=yoshitake.kobayashi@toshiba.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).