From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v7 2/8] scsi: ufs-qcom: fix compilation warning if compiled as a module Date: Wed, 2 Sep 2015 15:28:56 -0500 Message-ID: References: <1441205138-12664-1-git-send-email-ygardi@codeaurora.org> <1441205138-12664-3-git-send-email-ygardi@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1441205138-12664-3-git-send-email-ygardi@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Yaniv Gardi Cc: Jej B , Paul Bolle , hch@infradead.org, "linux-kernel@vger.kernel.org" , linux-scsi@vger.kernel.org, linux-arm-msm , Santosh Y , linux-scsi-owner@vger.kernel.org, Subhash Jadavani , Gilad Broner , Dolev Raviv , Vinayak Holikatti , "James E.J. Bottomley" List-Id: linux-scsi@vger.kernel.org On Wed, Sep 2, 2015 at 9:45 AM, Yaniv Gardi wrote: > This change fixes a compilation warning that happens if SCSI_UFS_QCOM > is compiled as a module. > Also this patch fixes an error happens when insmod the module: > "ufs_qcom: module license 'unspecified' taints kernel." > > Signed-off-by: Yaniv Gardi > > --- > drivers/scsi/ufs/ufs-qcom.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index 4cdffa4..6c23bbf 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -917,12 +917,15 @@ out: > > #define ANDROID_BOOT_DEV_MAX 30 > static char android_boot_dev[ANDROID_BOOT_DEV_MAX]; > -static int get_android_boot_dev(char *str) What is this Android crap doing in a driver to begin with? Rob