linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saurav Kashyap <saurav.kashyap@qlogic.com>
To: James Bottomley <jbottomley@parallels.com>,
	Fengguang Wu <fengguang.wu@intel.com>
Cc: Yuanhan Liu <yuanhan.liu@intel.com>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>,
	Chad Dupuis <chad.dupuis@qlogic.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function
Date: Mon, 17 Sep 2012 11:13:15 -0500	[thread overview]
Message-ID: <CC7D49BC.E02F%saurav.kashyap@qlogic.com> (raw)
In-Reply-To: <1347885307.2397.21.camel@dabdike.int.hansenpartnership.com>




>On Sat, 2012-09-15 at 07:57 +0800, Fengguang Wu wrote:
>> Hi Saurav,
>>
>> FYI, there are new compile warnings show up in
>>
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
>>for-next
>> head:   71cfff4af0525891941199b142b759d00b293959
>> commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI]
>>qla2xxx: Implementation of bidirectional.
>> config: x86_64-allmodconfig
>>
>> All error/warnings:
>>
>> drivers/scsi/qla2xxx/qla_isr.c: In function 'qla2x00_status_entry':
>> drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used
>>uninitialized in this function [-Wmaybe-uninitialized]
>> drivers/scsi/qla2xxx/qla_isr.c:1558:11: note: 'rval' was declared here
>
>Hmm, that's actually fixed by a later patch in the series:
>
>commit 2d7a7dc9bf4772b6ed711cadeee0bce9bace2a94
>Author: Saurav Kashyap <saurav.kashyap@qlogic.com>
>Date:   Wed Aug 22 14:21:12 2012 -0400
>
>    [SCSI] qla2xxx: Fix rval may be used uninitialized in this function
>warning.
>
>Note to qlogic: please don't do this in future.  I'll combine these two
>patches so we get a single series with no introduced and later fixed
>warnings.

Hi James,
We will take care of this in future.

Thanks,
~Saurav


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.


      reply	other threads:[~2012-09-17 16:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-14 23:57 [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function Fengguang Wu
2012-09-17 12:35 ` James Bottomley
2012-09-17 16:13   ` Saurav Kashyap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CC7D49BC.E02F%saurav.kashyap@qlogic.com \
    --to=saurav.kashyap@qlogic.com \
    --cc=chad.dupuis@qlogic.com \
    --cc=fengguang.wu@intel.com \
    --cc=jbottomley@parallels.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=yuanhan.liu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).