[scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

[scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

[Fengguang Wu]

Hi Saurav,

FYI, there are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
head:   71cfff4af0525891941199b142b759d00b293959
commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI] qla2xxx: Implementation of bidirectional.
config: x86_64-allmodconfig

All error/warnings:

drivers/scsi/qla2xxx/qla_isr.c: In function 'qla2x00_status_entry':
drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function [-Wmaybe-uninitialized]
drivers/scsi/qla2xxx/qla_isr.c:1558:11: note: 'rval' was declared here

It could be uninitialized due to the test in line 1598.

vim +1684 drivers/scsi/qla2xxx/qla_isr.c
  1596         switch (comp_status) {
  1597         case CS_COMPLETE:
> 1598                 if (scsi_status == 0) {
  1599                         bsg_job->reply->reply_payload_rcv_len =
  1600
  bsg_job->reply_payload.payload_len;
  1601                         rval = EXT_STATUS_OK;
  1602                 }
  1603                 goto done;
  1604 
...
  1674			ql_dbg(ql_dbg_user, vha, 0x70bb,
  1675			    "Command completed with completion status=0x%x "
  1676			    "thread_id=%d\n", comp_status, thread_id);
  1677			rval = EXT_STATUS_ERR;
  1678			break;
  1679		}
  1680			bsg_job->reply->reply_payload_rcv_len = 0;
  1681	
  1682	done:
  1683		/* Return the vendor specific reply to API */
> 1684		bsg_job->reply->reply_data.vendor_reply.vendor_rsp[0] = rval;
  1685		bsg_job->reply_len = sizeof(struct fc_bsg_reply);
  1686		/* Always return DID_OK, bsg will send the vendor specific response
  1687		 * in this case only */
  1688		sp->done(vha, sp, (DID_OK << 6));
  1689	
  1690	}

---
0-DAY kernel build testing backend         Open Source Technology Centre
Fengguang Wu, Yuanhan Liu                              Intel Corporation

Re: [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

[James Bottomley]

On Sat, 2012-09-15 at 07:57 +0800, Fengguang Wu wrote:
> Hi Saurav,
> 
> FYI, there are new compile warnings show up in
> 
> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next
> head:   71cfff4af0525891941199b142b759d00b293959
> commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI] qla2xxx: Implementation of bidirectional.
> config: x86_64-allmodconfig
> 
> All error/warnings:
> 
> drivers/scsi/qla2xxx/qla_isr.c: In function 'qla2x00_status_entry':
> drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function [-Wmaybe-uninitialized]
> drivers/scsi/qla2xxx/qla_isr.c:1558:11: note: 'rval' was declared here

Hmm, that's actually fixed by a later patch in the series:

commit 2d7a7dc9bf4772b6ed711cadeee0bce9bace2a94
Author: Saurav Kashyap <saurav.kashyap@qlogic.com>
Date:   Wed Aug 22 14:21:12 2012 -0400

    [SCSI] qla2xxx: Fix rval may be used uninitialized in this function
warning.

Note to qlogic: please don't do this in future.  I'll combine these two
patches so we get a single series with no introduced and later fixed
warnings.

James

Re: [scsi:for-next 92/128] drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used uninitialized in this function

[Saurav Kashyap]

>On Sat, 2012-09-15 at 07:57 +0800, Fengguang Wu wrote:
>> Hi Saurav,
>>
>> FYI, there are new compile warnings show up in
>>
>> tree:   git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git
>>for-next
>> head:   71cfff4af0525891941199b142b759d00b293959
>> commit: 387fddaa3564503c9f82d091d2ebe390f3af62a1 [92/128] [SCSI]
>>qla2xxx: Implementation of bidirectional.
>> config: x86_64-allmodconfig
>>
>> All error/warnings:
>>
>> drivers/scsi/qla2xxx/qla_isr.c: In function 'qla2x00_status_entry':
>> drivers/scsi/qla2xxx/qla_isr.c:1684:56: warning: 'rval' may be used
>>uninitialized in this function [-Wmaybe-uninitialized]
>> drivers/scsi/qla2xxx/qla_isr.c:1558:11: note: 'rval' was declared here
>
>Hmm, that's actually fixed by a later patch in the series:
>
>commit 2d7a7dc9bf4772b6ed711cadeee0bce9bace2a94
>Author: Saurav Kashyap <saurav.kashyap@qlogic.com>
>Date:   Wed Aug 22 14:21:12 2012 -0400
>
>    [SCSI] qla2xxx: Fix rval may be used uninitialized in this function
>warning.
>
>Note to qlogic: please don't do this in future.  I'll combine these two
>patches so we get a single series with no introduced and later fixed
>warnings.

Hi James,
We will take care of this in future.

Thanks,
~Saurav


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.