linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Saurav Kashyap <saurav.kashyap@qlogic.com>
To: Roland Dreier <roland@purestorage.com>,
	Chad Dupuis <chad.dupuis@qlogic.com>
Cc: "steve@purestorage.com" <steve@purestorage.com>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	Dept-Eng Linux Driver <Linux-Driver@qlogic.com>,
	Andrew Vasquez <andrew.vasquez@qlogic.com>,
	"James E.J. Bottomley" <JBottomley@parallels.com>
Subject: Re: [PATCH 0/2] Fix the qla2xxx loopback selftests
Date: Mon, 22 Oct 2012 11:06:56 -0500	[thread overview]
Message-ID: <CCAB6B63.F32A%saurav.kashyap@qlogic.com> (raw)
In-Reply-To: <CAL1RGDXtxmRS=D4vOW5rPEkCcjDxtP8B7EpU1Si1uejMLca2aA@mail.gmail.com>




>On Tue, Aug 14, 2012 at 2:15 PM, Chad Dupuis <chad.dupuis@qlogic.com>
>wrote:
>>
>>
>> On Tue, 14 Aug 2012, steve@purestorage.com wrote:
>>
>>> From: Steve Hodgson <steve@purestorage.com>
>>>
>>> A few months ago our 2.6.39 based kernel started crashing almost 100%
>>> of the time when running the selftests, after seeminly unrelated kernel
>>> changes. In the end it was traced down to this use after free.
>>>
>>> Whilst here fix an error path memory leak.
>>>
>>> Thanks,
>>>
>>> Steve
>>>
>>> Steve Hodgson (2):
>>>  qla2xxx: Fix use after free in qla2x000_process_loopback.
>>>  qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()
>>>
>>> drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
>>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>>
>>>
>>
>> Hi Steve, thanks for the patches. We'll look into them and let you know
>>if
>> there is anything extra needed.
>
>Looking at the 3.7-rc code, it looks like the use-after-free is still
>there.
>Any plans on merging these patches?

Hi Roland,
The above changes are applicable to other bsg calls also, the changes are
under test and will be submitted in the next submission.

Thanks,
~Saurav


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.


      reply	other threads:[~2012-10-22 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-14 15:48 [PATCH 0/2] Fix the qla2xxx loopback selftests steve
2012-08-14 21:15 ` Chad Dupuis
2012-10-22 15:46   ` Roland Dreier
2012-10-22 16:06     ` Saurav Kashyap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CCAB6B63.F32A%saurav.kashyap@qlogic.com \
    --to=saurav.kashyap@qlogic.com \
    --cc=JBottomley@parallels.com \
    --cc=Linux-Driver@qlogic.com \
    --cc=andrew.vasquez@qlogic.com \
    --cc=chad.dupuis@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=roland@purestorage.com \
    --cc=steve@purestorage.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).