[PATCH 0/2] Fix the qla2xxx loopback selftests

[PATCH 0/2] Fix the qla2xxx loopback selftests

[steve]

From: Steve Hodgson <steve@purestorage.com>

A few months ago our 2.6.39 based kernel started crashing almost 100%
of the time when running the selftests, after seeminly unrelated kernel
changes. In the end it was traced down to this use after free.

Whilst here fix an error path memory leak.

Thanks,

Steve

Steve Hodgson (2):
  qla2xxx: Fix use after free in qla2x000_process_loopback.
  qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()

 drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

-- 
1.7.9.5

Re: [PATCH 0/2] Fix the qla2xxx loopback selftests

[Chad Dupuis]

On Tue, 14 Aug 2012, steve@purestorage.com wrote:

> From: Steve Hodgson <steve@purestorage.com>
>
> A few months ago our 2.6.39 based kernel started crashing almost 100%
> of the time when running the selftests, after seeminly unrelated kernel
> changes. In the end it was traced down to this use after free.
>
> Whilst here fix an error path memory leak.
>
> Thanks,
>
> Steve
>
> Steve Hodgson (2):
>  qla2xxx: Fix use after free in qla2x000_process_loopback.
>  qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()
>
> drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
>
>

Hi Steve, thanks for the patches. We'll look into them and let you know if
there is anything extra needed.

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

Re: [PATCH 0/2] Fix the qla2xxx loopback selftests

[Roland Dreier]

On Tue, Aug 14, 2012 at 2:15 PM, Chad Dupuis <chad.dupuis@qlogic.com> wrote:
>
>
> On Tue, 14 Aug 2012, steve@purestorage.com wrote:
>
>> From: Steve Hodgson <steve@purestorage.com>
>>
>> A few months ago our 2.6.39 based kernel started crashing almost 100%
>> of the time when running the selftests, after seeminly unrelated kernel
>> changes. In the end it was traced down to this use after free.
>>
>> Whilst here fix an error path memory leak.
>>
>> Thanks,
>>
>> Steve
>>
>> Steve Hodgson (2):
>>  qla2xxx: Fix use after free in qla2x000_process_loopback.
>>  qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()
>>
>> drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>
>>
>
> Hi Steve, thanks for the patches. We'll look into them and let you know if
> there is anything extra needed.

Looking at the 3.7-rc code, it looks like the use-after-free is still there.
Any plans on merging these patches?

 - R.

Re: [PATCH 0/2] Fix the qla2xxx loopback selftests

[Saurav Kashyap]

>On Tue, Aug 14, 2012 at 2:15 PM, Chad Dupuis <chad.dupuis@qlogic.com>
>wrote:
>>
>>
>> On Tue, 14 Aug 2012, steve@purestorage.com wrote:
>>
>>> From: Steve Hodgson <steve@purestorage.com>
>>>
>>> A few months ago our 2.6.39 based kernel started crashing almost 100%
>>> of the time when running the selftests, after seeminly unrelated kernel
>>> changes. In the end it was traced down to this use after free.
>>>
>>> Whilst here fix an error path memory leak.
>>>
>>> Thanks,
>>>
>>> Steve
>>>
>>> Steve Hodgson (2):
>>>  qla2xxx: Fix use after free in qla2x000_process_loopback.
>>>  qla2xxx: Free rsp_data even on error in qla2x00_process_loopback()
>>>
>>> drivers/scsi/qla2xxx/qla_bsg.c |   17 +++++++++--------
>>> 1 file changed, 9 insertions(+), 8 deletions(-)
>>>
>>>
>>
>> Hi Steve, thanks for the patches. We'll look into them and let you know
>>if
>> there is anything extra needed.
>
>Looking at the 3.7-rc code, it looks like the use-after-free is still
>there.
>Any plans on merging these patches?

Hi Roland,
The above changes are applicable to other bsg calls also, the changes are
under test and will be submitted in the next submission.

Thanks,
~Saurav


This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.