From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A602C3DA7A for ; Wed, 28 Dec 2022 11:53:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233000AbiL1Lxh (ORCPT ); Wed, 28 Dec 2022 06:53:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229868AbiL1Lxe (ORCPT ); Wed, 28 Dec 2022 06:53:34 -0500 Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E290B101F8 for ; Wed, 28 Dec 2022 03:53:30 -0800 (PST) Received: by mail-wm1-x336.google.com with SMTP id k26-20020a05600c1c9a00b003d972646a7dso7919955wms.5 for ; Wed, 28 Dec 2022 03:53:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fairphone.com; s=fair; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jIc8aJi8QrQvoJC03xAlMGnXDQaBLi9+Xeuw2xbs1CY=; b=IqTlpr+kOSYALPPG9hyn3C9MlIclYXZ7rmvtGH7avBSeuw0UUodYrtkyEnyOdeAAo8 i0fBxxV8jK97PO6KBukzq5ruUVd4+WlrDQubGUOmyxTAXnlc5mpPzO1a773G8VfRjrpt 5nwas47xCB6lLvtRpTpV01nuBknkPnkZ6yTrHfALUdCkJpVfeTqWcY7qB8CzRU/3AYX3 z7sUolaxeNYwAhmsjgplLToOE4xYZmtxU6fLSiXulUS/87GBU6Iok8fSHwwUXLp6u38j D0xKba8YxPKtTDorV053vnH+vcRZ89rq1wnFuWMpMLDSDtADRQkxmUhRrUmDiM16Sw38 qQ4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:references:subject:cc:to:from:message-id:date :content-transfer-encoding:mime-version:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=jIc8aJi8QrQvoJC03xAlMGnXDQaBLi9+Xeuw2xbs1CY=; b=Pn8/FmeSboHVJ9wmqVWT0WpPPnUR12eqzFHTC3TgkKlr3Oc9FK/4WA8sNK2MDh1smE IiXmK4etwsKHi0ABsARYUZKnewBsaI2MlEXWiag02qyL18B6q32YTcqZqynCRObelIF9 bzTgzHJZyuRW9L8VfS4IpFpvPaDXrMguJpGpKL1OIzLHPF/OvzhSnA2+bLY87kx6vpMg Jv71TFQZ4S9G3tVN4gccGiNCjnZ8wMC6QbGDa9eoGAUC9uAKhy8a8p1952dSXiInmYhC snop4S9MNfWOU14o0s38C+/ytSpO8k8L5T8WZrR1L4IKy791UJZ+UtnszCUXr1BcTz4s +ayg== X-Gm-Message-State: AFqh2kr78AGrJJuH0JyLGy2M5ykiRLKRc3mrZJ4yDyVyXnehT8kJ4yQ5 WzdHSRxNwsQaWWhHw1ayUhwGkw== X-Google-Smtp-Source: AMrXdXsHsKXYzrbgvBev4TqUTsvmYSdXTIKLuvACYlZVNAx/xPx9eOVDrIVvKi9OWOpGnsegvvTAow== X-Received: by 2002:a05:600c:34ce:b0:3cf:614e:b587 with SMTP id d14-20020a05600c34ce00b003cf614eb587mr18312059wmq.26.1672228409224; Wed, 28 Dec 2022 03:53:29 -0800 (PST) Received: from localhost (2a02-8388-6582-fe80-0000-0000-0000-0006.cable.dynamic.v6.surfer.at. [2a02:8388:6582:fe80::6]) by smtp.gmail.com with ESMTPSA id n25-20020a7bc5d9000000b003d969a595fbsm20730799wmk.10.2022.12.28.03.53.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Dec 2022 03:53:28 -0800 (PST) Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Date: Wed, 28 Dec 2022 12:53:27 +0100 Message-Id: From: "Luca Weiss" To: "Krzysztof Kozlowski" , <~postmarketos/upstreaming@lists.sr.ht>, , "Andy Gross" , "Bjorn Andersson" , "Konrad Dybcio" , "Alim Akhtar" , "Avri Altman" , "Bart Van Assche" , "Rob Herring" , "Krzysztof Kozlowski" Cc: , , , Subject: Re: [PATCH] dt-bindings: ufs: qcom: Add reg-names property for ICE X-Mailer: aerc 0.13.0 References: <20221209-dt-binding-ufs-v1-0-8d502f0e18d5@fairphone.com> In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org Hi Krzysztof, On Wed Dec 28, 2022 at 12:50 PM CET, Krzysztof Kozlowski wrote: > On 09/12/2022 15:29, Luca Weiss wrote: > > The code in ufs-qcom-ice.c needs the ICE reg to be named "ice". Add thi= s > > in the bindings so the existing dts can validate successfully. > >=20 > > Also sm8450 is using ICE since commit 276ee34a40c1 ("arm64: dts: qcom: > > sm8450: add Inline Crypto Engine registers and clock") so move the > > compatible to the correct if. > >=20 > > Signed-off-by: Luca Weiss > > --- > > (no cover subject) > >=20 > > The only remaining validation issues I see is the following on sc8280xp= -crd.dtb > > and sa8540p-ride.dtb: > >=20 > > Any plans on fixing the patch (after testing it) and resending? I wasn't quite sure how to fix the comments, but re-reading them this comment from you is how you expect it to be in v2? > Just add it to top-level with minItems: 1 and per variant customize: > 1. maxItems: 1 > 2. minItems: 2 + required If so I can spin v2 maybe today still. Regards Luca > > Best regards, > Krzysztof