Re: [PATCH 4/6] block: freeze queue for updating QUEUE_FLAG_NONROT

Bart Van Assche
2020-01-19T20:40:22Z

On 2020-01-18 23:14, Ming Lei wrote:
> +static ssize_t queue_store_nonrot_freeze(struct request_queue *q,
> + const char *page, size_t count)
> +{
> + size_t ret;
> +
> + blk_mq_freeze_queue(q);
> + ret = queue_store_nonrot(q, page, count);
> + blk_mq_unfreeze_queue(q);
> +
> + return ret;
> +}

Both queue_store_nonrot() and queue_store_nonrot_freeze() return a
signed integer but 'ret' is an unsigned integer. Is that perhaps the
result of an oversight?

Thanks,

Bart.