public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@qlogic.com>
To: Spencer Baugh <sbaugh@catern.com>,
	Chad Dupuis <chad.dupuis@qlogic.com>,
	Giridhar Malavali <giridhar.malavali@qlogic.com>,
	Saurav Kashyap <saurav.kashyap@qlogic.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>,
	linux-scsi <linux-scsi@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Cc: Joern Engel <joern@purestorage.com>,
	Spencer Baugh <Spencer.baugh@purestorage.com>,
	Joern Engel <joern@logfs.org>
Subject: Re: [PATCH] qla2xxx: remove unused rval
Date: Wed, 22 Jul 2015 22:17:24 +0000	[thread overview]
Message-ID: <D1D5644B.A614D%himanshu.madhani@qlogic.com> (raw)
In-Reply-To: <1437602898-15229-1-git-send-email-sbaugh@catern.com>

[-- Attachment #1: Type: text/plain, Size: 1478 bytes --]


On 7/22/15, 3:08 PM, "Spencer Baugh" <sbaugh@catern.com> wrote:

>From: Joern Engel <joern@logfs.org>
>
>We don't touch the return value of qla2x00_loop_resync in
>qla2x00_do_dpc, so don't bother collecting it. Fixes a compiler warning.
>
>Signed-off-by: Joern Engel <joern@logfs.org>
>Signed-off-by: Spencer Baugh <sbaugh@catern.com>
>---
> drivers/scsi/qla2xxx/qla_os.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>index a28815b..b9ee115 100644
>--- a/drivers/scsi/qla2xxx/qla_os.c
>+++ b/drivers/scsi/qla2xxx/qla_os.c
>@@ -4793,7 +4793,6 @@ qla2x00_disable_board_on_pci_error(struct
>work_struct *work)
> static int
> qla2x00_do_dpc(void *data)
> {
>-	int		rval;
> 	scsi_qla_host_t *base_vha;
> 	struct qla_hw_data *ha;
> 
>@@ -5025,7 +5024,7 @@ loop_resync_check:
> 			if (!(test_and_set_bit(LOOP_RESYNC_ACTIVE,
> 			    &base_vha->dpc_flags))) {
> 
>-				rval = qla2x00_loop_resync(base_vha);
>+				qla2x00_loop_resync(base_vha);
> 
> 				clear_bit(LOOP_RESYNC_ACTIVE,
> 						&base_vha->dpc_flags);
>-- 
>2.5.0.rc3
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/

Acked-by: Himanshu Madhani <himanshu.madhani@qlogic.com>


>


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 4568 bytes --]

      reply	other threads:[~2015-07-22 22:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-22 22:08 [PATCH] qla2xxx: remove unused rval Spencer Baugh
2015-07-22 22:17 ` Himanshu Madhani [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D1D5644B.A614D%himanshu.madhani@qlogic.com \
    --to=himanshu.madhani@qlogic.com \
    --cc=JBottomley@odin.com \
    --cc=Spencer.baugh@purestorage.com \
    --cc=chad.dupuis@qlogic.com \
    --cc=giridhar.malavali@qlogic.com \
    --cc=joern@logfs.org \
    --cc=joern@purestorage.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=saurav.kashyap@qlogic.com \
    --cc=sbaugh@catern.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox