From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quinn Tran Subject: Re: [PATCH 11/20] qla2xxx: Add TAS detection for kernel 3.15 n newer Date: Wed, 9 Dec 2015 20:24:57 +0000 Message-ID: References: <1449535747-2850-1-git-send-email-himanshu.madhani@qlogic.com> <1449535747-2850-12-git-send-email-himanshu.madhani@qlogic.com> <20151208024800.GA32255@infradead.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_D28DCACE1B0B1quinntranqlogiccom_" Return-path: Received: from mx0b-0016ce01.pphosted.com ([67.231.156.153]:63916 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751960AbbLIUXP (ORCPT ); Wed, 9 Dec 2015 15:23:15 -0500 Received: from pps.filterd (m0085408.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.15.0.59/8.15.0.59) with SMTP id tB9KLh8n001977 for ; Wed, 9 Dec 2015 12:23:14 -0800 Received: from avcashub1.qlogic.com (avcashub3.qlogic.com [198.70.193.117]) by mx0b-0016ce01.pphosted.com with ESMTP id 1ykystqpk0-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Wed, 09 Dec 2015 12:23:14 -0800 In-Reply-To: <20151208024800.GA32255@infradead.org> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Christoph Hellwig , Himanshu Madhani Cc: "target-devel@vger.kernel.org" , "nab@linux-iscsi.org" , Giridhar Malavali , linux-scsi --_000_D28DCACE1B0B1quinntranqlogiccom_ Content-Type: text/plain; charset="iso-8859-1" Content-ID: <8B58BCD6178D6945B48FE863809B862E@qlogic.com> Content-Transfer-Encoding: quoted-printable On 12/7/15, 6:48 PM, "target-devel-owner@vger.kernel.org on behalf of Christoph Hellwig" wrote: >> diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c >>b/drivers/scsi/qla2xxx/tcm_qla2xxx.c >> index 842fcca..2e9c194 100644 >> --- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c >> +++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c >> @@ -617,6 +617,26 @@ static int tcm_qla2xxx_queue_status(struct se_cmd >>*se_cmd) >> struct qla_tgt_cmd, se_cmd); >> int xmit_type =3D QLA_TGT_XMIT_STATUS; >> =20 >> + if (se_cmd->transport_state & CMD_T_ABORTED) { >> + /* For TCM TAS support n kernel >=3D 3.15: >> + * This cmd is attempting to respond with "Task Aborted Status". >> + */ >> + if (cmd->aborted) { >> + return 0; >> + } else if ((cmd->state =3D=3D QLA_TGT_STATE_NEED_DATA) && >> + cmd->cmd_sent_to_fw) { >> + qlt_abort_cmd(cmd); >> + return 0; >> + } else if (cmd->state =3D=3D QLA_TGT_STATE_PROCESSED) { >> + if (cmd->cmd_sent_to_fw) { >> + qlt_abort_cmd(cmd); >> + return 0; >> + } else { /* about to be free */ >> + return 0; >> + } >> + } >> + } >> + > >This is really something that should be explicitly communicated >from the core instead of having to second guess it. QT> The extra protection of the code here is to reduce erroneous error message and interaction error with our firmware. I think communicating back to the core at this stage might add undue complication. It=B9s best t= o allow the initiator to re-drive the command at this point. --_000_D28DCACE1B0B1quinntranqlogiccom_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IqxLAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAADczQjQwN0M3 NUEzQ0YxNEZCQ0Q1MkVENjYxNUQyQTYyAEgHAQ2ABAACAAAAAgACAAEFgAMADgAAAN8HDAAJABQA GAA5AAMAYwEBIIADAA4AAADfBwwACQAUABgAOQADAGMBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABAEUAAABSZTogW1BBVENIIDExLzIwXSBxbGEyeHh4OiBBZGQgVEFTIGRl dGVjdGlvbiBmb3Iga2VybmVsIDMuMTUgbiBuZXdlcgBMFQEDkAYAXBEAADQAAAACAX8AAQAAACcA AAA8RDI4RENBQ0UuMUIwQjElcXVpbm4udHJhbkBxbG9naWMuY29tPgAACwAfDgEAAAACAQkQAQAA APQEAADwBAAAFQkAAExaRnWNjvChYQAKZmJpZAQAAGNjwHBnMTI1MgD+A0PwdGV4dAH3AqQD4wIA BGNoCsBzZXQwIO8HbQKDAFARTTIKgAa0AoCWfQqACMg7CWIxOQ7AvwnDFnIKMhZxAoAVYioJsHMJ 8ASQYXQFsg5QA2Bzom8BgCBFeBHBbhgwXQZSdgSQF7YCEHIAwHR9CFBuGjEQIAXABaAbZGSaIANS IBAiF7JcdgiQ5HdrC4BkNR1TBPAHQA0XcDAKcRfyYmttawZzAZAAICBCTV9C4EVHSU59CvwB8Qvy amwLgGUKgE8DoA6QLwA3LzE1LCA2OqA0OCBQTSKgIh9xGRgwdC0BABowbC1vEncYUUB2GDByLmtL BJEkAC4FsGcgAiAgpGJlEdBsZiWAZiGVDENoBRAfYG9waCAKSCQAbAPwZyIgPK8jbyR/JY8h0WgR wEALgB0DUGEBACvgKeI+IHfbA2AQIDohlSGVPixwDeBBASAgLS1naQVAYcwvZAUQGjFzLwTwAJAk L3ELYDJ4L+AvdGhjbV8vpS4A4C12Yjcuzy/fMOggHbEQMCA4DDQyEbAeUC4uMmU0OWMWcDQiIB6g NjR2NC1oLlAtLq8yjzObK5858CpQNy84PzO5QEAuQGA2MTcsNjngPVIy9z2QPREfYXQOUDRRBUA7 qRc70ApQClBfPmJ1cyixH2BydWMFQBIAXzuw6wswLXYqQRQpLWgDMAyTD0NYPlFAwzshX3RndD9B MiKgQhUWIEKcPsN4bRMugETgeXAZ4D0gUQBMQV9UR1RfWARNSUhgU1RBVFV+U0X7OWhGtCYQQJBB Iy12PkCwAHFwCRFAIxngJhAgQ01ESDBfQULAT1JURUQpAzAAAENKDEPzLyogRgWxVItM0BJAQQXw c3VwTAImIAOgKYQgPkfgMy6XIoAs5k5bIE8wVGgEAL8b0EFQNFAEIBiAECBtBTD3C4AqEBiQIAlw S/EdwCyAAy6AJ0AiVGFzayCWQQbgHDNTQEMiLlGv/VKzL1bvSsVLYwGgVgNNr29DmQlwQGAEoTBF +U6IXHx9ICigEgBK41nETFQ9Q0foSNJFX05FTYBfykRI8EFakCYmXO9Ssj9isUtjQUFAIAnwR3Fv X/xmd1qfQ5k7IEUQWiNBMv9ZwkXqW39cj12fWZdfT2BUgFBST0NFU1NNj/9De1mXY19tv2U/Zk9x L2gv33Pvag1w0U7lWiF1PvFUkP8lwBxxCeBYL3TPdd927Xxf/32vfv8tZi1mUxNTMQlwB0D8bHk+ UANwEhBTIFRSEdD1QPFoCGBsHGB5YRAwC1CPDlAugILhBaBtbXUDAO8eUBxBLWYchGgZ4AWhXoHv AIAQICvgJiEgEdAdYFRU9xIAG+EcYGcKUAQRLoBW1nkhlVFULHBTEISCS7Eg9nAsokDgaSoxh/GG 5AEA34gQBJBegQQgVINkQNCEgb5yA2AYUAhgBCCOEnIhlfkHgXNhGdEAcFOBAjAYYV+L1I6zVSQI YRxwaRsAd+EKwGUuIEmDoQuAVcD3hVhUQSGVYgDQVcBUgYbnP4PRg1EEIB9hGdFHUGdo/S6RZBxg hZCNwIcCVBCE0Q8+gQIgkmCScHRcJ0L+OQQgJcAfYFRxIZWCwSjQ/4bTC4AugAcwGJJUgyhgOmL/ htWFcI/ylVZMAD7Rib0VQgGeQB8AQgABAAAAFgAAAFEAdQBpAG4AbgAgAFQAcgBhAG4AAAAAAB8A ZQABAAAALAAAAHEAdQBpAG4AbgAuAHQAcgBhAG4AQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwBk AAEAAAAKAAAAUwBNAFQAUAAAAAAAAgFBAAEAAABkAAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACA UQB1AGkAbgBuACAAVAByAGEAbgAAAFMATQBUAFAAAABxAHUAaQBuAG4ALgB0AHIAYQBuAEAAcQBs AG8AZwBpAGMALgBjAG8AbQAAAB8AAl0BAAAALAAAAHEAdQBpAG4AbgAuAHQAcgBhAG4AQABxAGwA bwBnAGkAYwAuAGMAbwBtAAAAHwDlXwEAAAA0AAAAcwBpAHAAOgBxAHUAaQBuAG4ALgB0AHIAYQBu AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AGgwBAAAAFgAAAFEAdQBpAG4AbgAgAFQAcgBhAG4A AAAAAB8AHwwBAAAALAAAAHEAdQBpAG4AbgAuAHQAcgBhAG4AQABxAGwAbwBnAGkAYwAuAGMAbwBt AAAAHwAeDAEAAAAKAAAAUwBNAFQAUAAAAAAAAgEZDAEAAABkAAAAAAAAAIErH6S+oxAZnW4A3QEP VAIAAACAUQB1AGkAbgBuACAAVAByAGEAbgAAAFMATQBUAFAAAABxAHUAaQBuAG4ALgB0AHIAYQBu AEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AAV0BAAAALAAAAHEAdQBpAG4AbgAuAHQAcgBhAG4A QABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwD4PwEAAAAWAAAAUQB1AGkAbgBuACAAVAByAGEAbgAA AAAAHwAjQAEAAAAsAAAAcQB1AGkAbgBuAC4AdAByAGEAbgBAAHEAbABvAGcAaQBjAC4AYwBvAG0A AAAfACJAAQAAAAoAAABTAE0AVABQAAAAAAACAfk/AQAAAGQAAAAAAAAAgSsfpL6jEBmdbgDdAQ9U AgAAAIBRAHUAaQBuAG4AIABUAHIAYQBuAAAAUwBNAFQAUAAAAHEAdQBpAG4AbgAuAHQAcgBhAG4A QABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAJXQEAAAAsAAAAcQB1AGkAbgBuAC4AdAByAGEAbgBA AHEAbABvAGcAaQBjAC4AYwBvAG0AAAALAEA6AQAAAB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQA ZQAAAAAAAwDxPwkEAAALAEA6AQAAAAMA/T/kBAAAAgELMAEAAAAQAAAAc7QHx1o88U+81S7WYV0q YgMAFwABAAAAQAA5AIAyoKu/MtEBQAAIMFMUIay/MtEBCwAAgAggBgAAAAAAwAAAAAAAAEYAAAAA FIUAAAEAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAeAAAAYQBjAGMAZQBwAHQAbABhAG4AZwB1 AGEAZwBlAAAAAAABAAAADAAAAGUAbgAtAFUAUwAAAAsAAIAIIAYAAAAAAMAAAAAAAABGAAAAAAaF AAAAAAAAHwA3AAEAAACKAAAAUgBlADoAIABbAFAAQQBUAEMASAAgADEAMQAvADIAMABdACAAcQBs AGEAMgB4AHgAeAA6ACAAQQBkAGQAIABUAEEAUwAgAGQAZQB0AGUAYwB0AGkAbwBuACAAZgBvAHIA IABrAGUAcgBuAGUAbAAgADMALgAxADUAIABuACAAbgBlAHcAZQByAAAAAAAfAD0AAQAAAAoAAABS AGUAOgAgAAAAAAADADYAAAAAAB8AQhABAAAATgAAADwAMgAwADEANQAxADIAMAA4ADAAMgA0ADgA MAAwAC4ARwBBADMAMgAyADUANQBAAGkAbgBmAHIAYQBkAGUAYQBkAC4AbwByAGcAPgAAAAAAAgFx AAEAAAAgAAAAAQHRMVf9gUhvFcEeLECLFtzcTmiDWp7A6R8AgAIzCAAfAHAAAQAAAIIAAABbAFAA QQBUAEMASAAgADEAMQAvADIAMABdACAAcQBsAGEAMgB4AHgAeAA6ACAAQQBkAGQAIABUAEEAUwAg AGQAZQB0AGUAYwB0AGkAbwBuACAAZgBvAHIAIABrAGUAcgBuAGUAbAAgADMALgAxADUAIABuACAA bgBlAHcAZQByAAAAAAAfADUQAQAAAE4AAAA8AEQAMgA4AEQAQwBBAEMARQAuADEAQgAwAEIAMQAl AHEAdQBpAG4AbgAuAHQAcgBhAG4AQABxAGwAbwBnAGkAYwAuAGMAbwBtAD4AAAAAAB8AORABAAAA TAEAADwAMQA0ADQAOQA1ADMANQA3ADQANwAtADIAOAA1ADAALQAxAC0AZwBpAHQALQBzAGUAbgBk AC0AZQBtAGEAaQBsAC0AaABpAG0AYQBuAHMAaAB1AC4AbQBhAGQAaABhAG4AaQBAAHEAbABvAGcA aQBjAC4AYwBvAG0APgAgADwAMQA0ADQAOQA1ADMANQA3ADQANwAtADIAOAA1ADAALQAxADIALQBn AGkAdAAtAHMAZQBuAGQALQBlAG0AYQBpAGwALQBoAGkAbQBhAG4AcwBoAHUALgBtAGEAZABoAGEA bgBpAEAAcQBsAG8AZwBpAGMALgBjAG8AbQA+ACAAPAAyADAAMQA1ADEAMgAwADgAMAAyADQAOAAw ADAALgBHAEEAMwAyADIANQA1AEAAaQBuAGYAcgBhAGQAZQBhAGQALgBvAHIAZwA+AAAAAwDeP69v AABAAAcw0o4XrL8y0QEDACYAAAAAAAIBRwABAAAALwAAAGM9VVM7YT0gO3A9UUxvZ2ljO2w9QVZN QjItMTUxMjA5MjAyNDU3Wi0xMTQ4MTkAAB8AFRABAAAAWAAAADgAQgA1ADgAQgBDAEQANgAxADcA OABEADYAOQA0ADUAQgA0ADgARgBFADgANgAzADgAMAA5AEIAOAA2ADIARQBAAHEAbABvAGcAaQBj AC4AYwBvAG0AAAACARQwAQAAAAwAAACdAAAAldcNYU8AAAAfAPo/AQAAABYAAABRAHUAaQBuAG4A IABUAHIAYQBuAAAAAAAfAACAhgMCAAAAAADAAAAAAAAARgEAAAAWAAAAdQBzAGUAcgAtAGEAZwBl AG4AdAAAAAAAAQAAAEYAAABNAGkAYwByAG8AcwBvAGYAdAAtAE0AYQBjAE8AdQB0AGwAbwBvAGsA LwAxADQALgA1AC4ANQAuADEANQAwADgAMgAxAAAAAAAfAACAH6TrM6h6LkK+e3nhqY5UswEAAAA4 AAAAQwBvAG4AdgBlAHIAcwBhAHQAaQBvAG4ASQBuAGQAZQB4AFQAcgBhAGMAawBpAG4AZwBFAHgA AAABAAAAHgEAAEkASQA9ADAAMQAwADEARAAxADMAMgBCAEYANgBEADgANgA4ADcARgA1ADAANwA5 ADUANgBBADYAQgA0ADAAOAA0ADgAQgA0AEYAMQBCAEEANQAxAEIANgBDAEYARAA7AFMAQgBNAEkA RAA9ADQAOwBTADEAPQA8ADIAMAAxADUAMQAyADAAOAAwADIANAA4ADAAMAAuAEcAQQAzADIAMgA1 ADUAQABpAG4AZgByAGEAZABlAGEAZAAuAG8AcgBnAD4AOwBWAGUAcgBzAGkAbwBuAD0AVgBlAHIA cwBpAG8AbgAgADEANAAuADMAIAAoAEIAdQBpAGwAZAAgADIAMwA1AC4AMAApACwAIABTAHQAYQBn AGUAPQBIADIAAAAAAAMADTT9PwAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAIAAAAHgALQBtAHMA LQBoAGEAcwAtAGEAdAB0AGEAYwBoAAAAAQAAAAIAAAAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYB AAAAIgAAAHgALQBvAHIAaQBnAGkAbgBhAHQAaQBuAGcALQBpAHAAAAAAAAEAAAAaAAAAWwAxADAA LgA4AC4ANQAuADIANQAwAF0AAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABYAAABkAGkAcwBj AGwAYQBpAG0AZQByAAAAAAABAAAADgAAAGIAeQBwAGEAcwBzAAAAAADvhw== --_000_D28DCACE1B0B1quinntranqlogiccom_--