From mboxrd@z Thu Jan 1 00:00:00 1970 From: Himanshu Madhani Subject: Re: [PATCH] qla2xxx: avoid maybe_uninitialized warning Date: Wed, 16 Mar 2016 14:05:07 +0000 Message-ID: References: <1458078051-529344-1-git-send-email-arnd@arndb.de> <1458078554.2375.97.camel@linux.vnet.ibm.com> <2808565.5VeioJTJAb@wuerfel> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="_000_D30EB4C2DE792himanshumadhaniqlogiccom_" Return-path: Received: from mx0a-0016ce01.pphosted.com ([67.231.148.157]:52693 "EHLO mx0b-0016ce01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932868AbcCPOFK (ORCPT ); Wed, 16 Mar 2016 10:05:10 -0400 Received: from pps.filterd (m0095336.ppops.net [127.0.0.1]) by mx0b-0016ce01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u2GE2woE010930 for ; Wed, 16 Mar 2016 07:05:09 -0700 Received: from avcashub1.qlogic.com ([198.186.0.115]) by mx0a-0016ce01.pphosted.com with ESMTP id 21my0febe5-1 (version=TLSv1 cipher=AES128-SHA bits=128 verify=NOT) for ; Wed, 16 Mar 2016 07:05:09 -0700 In-Reply-To: <2808565.5VeioJTJAb@wuerfel> Content-Language: en-US Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Arnd Bergmann , James Bottomley Cc: Dept-Eng QLA2xxx Upstream , "Martin K. Petersen" , Nicholas Bellinger , Quinn Tran , Alexei Potashnik , Bart Van Assche , Swapnil Nagle , linux-scsi , linux-kernel --_000_D30EB4C2DE792himanshumadhaniqlogiccom_ Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On 3/16/16, 5:59 AM, "Arnd Bergmann" wrote: >On Tuesday 15 March 2016 14:49:14 James Bottomley wrote: >> On Tue, 2016-03-15 at 22:40 +0100, Arnd Bergmann wrote: >> >=20 >> > This slightly rearranges the code to move the second if() block >> > into the first one, to avoid the warning while retaining the >> > behavior of the code. >>=20 >> I thought our usual policy was to ask someone to fix the compiler when >> it emitted a spurious warning. > >No, the rule is that we shouldn't blindly add initializations to >the variables when the compiler should have figured it out. > >In this case, I wouldn't expect the compiler to ever see through >the unlikely() macro, and I'm not adding a potentially counterproductive >initialization, so I see no reason not to apply the patch. I would like to keep unlikely() macro in the code. This patch looks good. Acked-By: Himanshu Madhani > >Making it easier for the compiler to figure out what is going >on should also lead to slightly better object code. If you think >my patch makes it less readable, an alternative would be to remove >the 'unlikely', which also gets rid of the warning. > > Arnd --_000_D30EB4C2DE792himanshumadhaniqlogiccom_ Content-Disposition: attachment; filename="winmail.dat" Content-Transfer-Encoding: base64 Content-Type: application/ms-tnef; name="winmail.dat" eJ8+IslgAQaQCAAEAAAAAAABAAEAAQeQBgAIAAAA5AQAAAAAAADoAAEJgAEAIQAAAEZEM0I5QUY5 ODE3Njk0NDdCRDQ5RThDMjYxNDRCMzg5AEAHAQ2ABAACAAAAAgACAAEFgAMADgAAAOAHAwAQAA4A BQAHAAMAFwEBIIADAA4AAADgBwMAEAAOAAUABwADABcBAQiABwAYAAAASVBNLk1pY3Jvc29mdCBN YWlsLk5vdGUAMQgBBIABADcAAABSZTogW1BBVENIXSBxbGEyeHh4OiBhdm9pZCBtYXliZV91bmlu aXRpYWxpemVkIHdhcm5pbmcAuhMBA5AGAPgQAAA0AAAAAgF/AAEAAAAtAAAAPEQzMEVCNEMyLkRF NzkyJWhpbWFuc2h1Lm1hZGhhbmlAcWxvZ2ljLmNvbT4AAAAACwAfDgEAAAACAQkQAQAAAFgEAABU BAAAuwYAAExaRnX/pXHVYQAKZmJpZAQAAGNjwHBnMTI1MgD+A0PwdGV4dAH3AqQD4wIABGNoCsBz ZXQwIO8HbQKDAFARTTIKgAa0AoCWfQqACMg7CWIxOQ7AvwnDFnIKMhZxAoAVYioJsHMJ8ASQYXQF sg5QA2Bzom8BgCBFeBHBbhgwXQZSdgSQF7YCEHIAwHR9CFBuGjEQIAXABaAbZGSaIANSIBAiF7Jc dgiQ5HdrC4BkNR1TBPAHQA0XcDAKcRfyYmttawZzAZAAICBCTV9C4EVHSU59CvwB8QvyWmwLgGUK gSGkTwOgMwgvMTYisSwgNTqgNTkgQU0jECIHEBcdwB+wBJBnA4FuIiCWPArAHcBAJNJiLgEAWD4g dwNgECA6IZw+BSJxVApQc2RheSDcMTUF0ArAEcAgAdAiwEEnsDQ6NDk6KKAgtEphB4JCJeAYkG0e cHsnoCXLPiWgJxQjEChSLbgwMy0nwRiAKEAyKMD9EjArKGAeoCMQI9sqLyWgSS6qVGgEACBzIaBn +Gh0bCegCXAKwBhwGcF5BCB0aBngBaABABzAb/4gBGAaMDGjEgAb4RxgBpCIKCkgAmBvY2suqucL gDJBMbJmaRHwBUACIGMrgTJBYXZvDdAxo3f7JNELgGclsDAwHnAw8QGQzwuANyIxsS6qYmUR0B1g twWxGTAxpy4qmCqYSTGhDwhgMKE1sAhwIHVzdbkHQCBwBvAOUCoRYTGR2TYhc2swYANwZTXBMjLl NWB4MaVtcDeBBcA3YMsJ8CqYaQVAZW1A4BxC+mEwYHAIcQhgBCA25TqXmSaWTm818THBcnU3kTcw QTGwLGF3MuE8EWxkPG4nBUACYB2xMNFhZMszUQMAdAcxaXoYgDmg7wYxGJAmljGydgrABzACYG8H kUACPyxFRCA5cTVCZ68IcBxRQOEIYHRCv0lJUt8wQR5QEgAjEDvgd0VmEDDecAWQBUA/OzJBZRox MvFPMqIDYDwxR8p1biGga/5lMNAzkQDBA2AjEABwHGD0SSccsG4l4EZSNyJBkP89IBAgAjAHMTDR BaBRsBuh0nADYGR1TsBpGjAmlv9GrCMQGSA70VBCU1Aw8hkg9wOgU1I2EnALUCegMbIKsN50EcA6 liGVTdUgUdIyMvlR8GVwUa80wToIMBRZs0lbYG9vH1AgZ17gZA1aDUEz8AmALUJ5OkwgSAdwAHFo dSfhZN0ZoWkksDAwYSQuAMBhs9RAcQkAZw5QLj9xQzb/Qs4n8B2hN0BA4j2gCJEccP8FsU7+SwRL ojdRLGEwQV8w/zchJpZYcUpFB0BXcR5wRmCfMjIwdzlQQUE5wWJqTrK1XcRJOfB5CGBNEm40B/5t J6BedADAUfAEIEDhSOF/BCAxASeASNFSsmoxG6Fu/0cxMpFbFDlQMjIJcDJyR8r6J1G2JyMQN2Eo IWpDGDD+dG9xNnE55UJPQtYBkS1TByGcFUJ4oB8AQgABAAAAIgAAAEgAaQBtAGEAbgBzAGgAdQAg AE0AYQBkAGgAYQBuAGkAAAAAAB8AZQABAAAAOAAAAGgAaQBtAGEAbgBzAGgAdQAuAG0AYQBkAGgA YQBuAGkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwBkAAEAAAAKAAAAUwBNAFQAUAAAAAAAAgFB AAEAAAB8AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACASABpAG0AYQBuAHMAaAB1ACAATQBhAGQA aABhAG4AaQAAAFMATQBUAFAAAABoAGkAbQBhAG4AcwBoAHUALgBtAGEAZABoAGEAbgBpAEAAcQBs AG8AZwBpAGMALgBjAG8AbQAAAB8AAl0BAAAAOAAAAGgAaQBtAGEAbgBzAGgAdQAuAG0AYQBkAGgA YQBuAGkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwDlXwEAAABAAAAAcwBpAHAAOgBoAGkAbQBh AG4AcwBoAHUALgBtAGEAZABoAGEAbgBpAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AGgwBAAAA IgAAAEgAaQBtAGEAbgBzAGgAdQAgAE0AYQBkAGgAYQBuAGkAAAAAAB8AHwwBAAAAOAAAAGgAaQBt AGEAbgBzAGgAdQAuAG0AYQBkAGgAYQBuAGkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAeDAEA AAAKAAAAUwBNAFQAUAAAAAAAAgEZDAEAAAB8AAAAAAAAAIErH6S+oxAZnW4A3QEPVAIAAACASABp AG0AYQBuAHMAaAB1ACAATQBhAGQAaABhAG4AaQAAAFMATQBUAFAAAABoAGkAbQBhAG4AcwBoAHUA LgBtAGEAZABoAGEAbgBpAEAAcQBsAG8AZwBpAGMALgBjAG8AbQAAAB8AAV0BAAAAOAAAAGgAaQBt AGEAbgBzAGgAdQAuAG0AYQBkAGgAYQBuAGkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwD4PwEA AAAiAAAASABpAG0AYQBuAHMAaAB1ACAATQBhAGQAaABhAG4AaQAAAAAAHwAjQAEAAAA4AAAAaABp AG0AYQBuAHMAaAB1AC4AbQBhAGQAaABhAG4AaQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAAfACJA AQAAAAoAAABTAE0AVABQAAAAAAACAfk/AQAAAHwAAAAAAAAAgSsfpL6jEBmdbgDdAQ9UAgAAAIBI AGkAbQBhAG4AcwBoAHUAIABNAGEAZABoAGEAbgBpAAAAUwBNAFQAUAAAAGgAaQBtAGEAbgBzAGgA dQAuAG0AYQBkAGgAYQBuAGkAQABxAGwAbwBnAGkAYwAuAGMAbwBtAAAAHwAJXQEAAAA4AAAAaABp AG0AYQBuAHMAaAB1AC4AbQBhAGQAaABhAG4AaQBAAHEAbABvAGcAaQBjAC4AYwBvAG0AAAALAEA6 AQAAAB8AGgABAAAAEgAAAEkAUABNAC4ATgBvAHQAZQAAAAAAAwDxPwkEAAALAEA6AQAAAAMA/T/k BAAAAgELMAEAAAAQAAAA/Tua+YF2lEe9SejCYUSziQMAFwABAAAAQAA5AICrNdiMf9EBQAAIMBsD ldiMf9EBCwAAgAggBgAAAAAAwAAAAAAAAEYAAAAAFIUAAAEAAAAfAACAhgMCAAAAAADAAAAAAAAA RgEAAAAeAAAAYQBjAGMAZQBwAHQAbABhAG4AZwB1AGEAZwBlAAAAAAABAAAADAAAAGUAbgAtAFUA UwAAAAsAAIAIIAYAAAAAAMAAAAAAAABGAAAAAAaFAAAAAAAAHwA3AAEAAABuAAAAUgBlADoAIABb AFAAQQBUAEMASABdACAAcQBsAGEAMgB4AHgAeAA6ACAAYQB2AG8AaQBkACAAbQBhAHkAYgBlAF8A dQBuAGkAbgBpAHQAaQBhAGwAaQB6AGUAZAAgAHcAYQByAG4AaQBuAGcAAAAAAB8APQABAAAACgAA AFIAZQA6ACAAAAAAAAMANgAAAAAAHwBCEAEAAAA6AAAAPAAyADgAMAA4ADUANgA1AC4ANQBWAGUA aQBvAEoAVABKAEEAYgBAAHcAdQBlAHIAZgBlAGwAPgAAAAAAAgFxAAEAAAAlAAAAAQHRfwNhLHWE XYBp2kGN3yfDCJnuDZ9bgFkAgAD+aoD//5zagAAAAB8AcAABAAAAZgAAAFsAUABBAFQAQwBIAF0A IABxAGwAYQAyAHgAeAB4ADoAIABhAHYAbwBpAGQAIABtAGEAeQBiAGUAXwB1AG4AaQBuAGkAdABp AGEAbABpAHoAZQBkACAAdwBhAHIAbgBpAG4AZwAAAAAAHwA1EAEAAABaAAAAPABEADMAMABFAEIA NABDADIALgBEAEUANwA5ADIAJQBoAGkAbQBhAG4AcwBoAHUALgBtAGEAZABoAGEAbgBpAEAAcQBs AG8AZwBpAGMALgBjAG8AbQA+AAAAAAAfADkQAQAAAPwAAAA8ADEANAA1ADgAMAA3ADgAMAA1ADEA LQA1ADIAOQAzADQANAAtADEALQBnAGkAdAAtAHMAZQBuAGQALQBlAG0AYQBpAGwALQBhAHIAbgBk AEAAYQByAG4AZABiAC4AZABlAD4AIAA8ADEANAA1ADgAMAA3ADgANQA1ADQALgAyADMANwA1AC4A OQA3AC4AYwBhAG0AZQBsAEAAbABpAG4AdQB4AC4AdgBuAGUAdAAuAGkAYgBtAC4AYwBvAG0APgAg ADwAMgA4ADAAOAA1ADYANQAuADUAVgBlAGkAbwBKAFQASgBBAGIAQAB3AHUAZQByAGYAZQBsAD4A AAADAN4/n04AAEAABzBcQJDYjH/RAQMAJgAAAAAAAgFHAAEAAAAvAAAAYz1VUzthPSA7cD1RTG9n aWM7bD1BVk1CMy0xNjAzMTYxNDA1MDdaLTE0OTQxNgAAHwAVEAEAAABYAAAARAAwADEAMQA1AEUA OAAwAEMARABGADcAQwA1ADQANQA5AEQANwAwADgARAAyAEIARQBFADEARQA3ADcARQBGAEAAcQBs AG8AZwBpAGMALgBjAG8AbQAAAAIBFDABAAAADAAAALMAAAAcGoUYTwAAAB8A+j8BAAAAIgAAAEgA aQBtAGEAbgBzAGgAdQAgAE0AYQBkAGgAYQBuAGkAAAAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAA ABYAAAB1AHMAZQByAC0AYQBnAGUAbgB0AAAAAAABAAAARgAAAE0AaQBjAHIAbwBzAG8AZgB0AC0A TQBhAGMATwB1AHQAbABvAG8AawAvADEANAAuADUALgA5AC4AMQA1ADEAMQAxADkAAAAAAB8AAIAf pOszqHouQr57eeGpjlSzAQAAADgAAABDAG8AbgB2AGUAcgBzAGEAdABpAG8AbgBJAG4AZABlAHgA VAByAGEAYwBrAGkAbgBnAEUAeAAAAAEAAAAKAQAASQBJAD0AMAAxADAAMQBEADEANwBGADgAQwBE ADgARQAxADcAQwAwAEQANgBCAEUAMQA1ADcARQA4ADQARAA4ADcANAAzADQANgBBADAAQwA3ADEA RQA2AEYARABFADsAUwBCAE0ASQBEAD0AMwA7AFMAMQA9ADwAMgA4ADAAOAA1ADYANQAuADUAVgBl AGkAbwBKAFQASgBBAGIAQAB3AHUAZQByAGYAZQBsAD4AOwBWAGUAcgBzAGkAbwBuAD0AVgBlAHIA cwBpAG8AbgAgADEANAAuADMAIAAoAEIAdQBpAGwAZAAgADIAMwA1AC4AMAApACwAIABTAHQAYQBn AGUAPQBIADIAAAAAAAMADTT9PwAAHwAAgIYDAgAAAAAAwAAAAAAAAEYBAAAAIAAAAHgALQBtAHMA LQBoAGEAcwAtAGEAdAB0AGEAYwBoAAAAAQAAAAIAAAAAAAAAHwAAgIYDAgAAAAAAwAAAAAAAAEYB AAAAIgAAAHgALQBvAHIAaQBnAGkAbgBhAHQAaQBuAGcALQBpAHAAAAAAAAEAAAAcAAAAWwAxADAA LgAyADkALgA3AC4AMQA1ADEAXQAAAB8AAICGAwIAAAAAAMAAAAAAAABGAQAAABYAAABkAGkAcwBj AGwAYQBpAG0AZQByAAAAAAABAAAADgAAAGIAeQBwAGEAcwBzAAAAAABWcA== --_000_D30EB4C2DE792himanshumadhaniqlogiccom_--