From: Nilesh Javali <nilesh.javali@qlogic.com>
To: Baoyou Xie <baoyou.xie@linaro.org>,
Dept-Eng QLogic Storage Upstream
<QLogic-Storage-Upstream@qlogic.com>,
"jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
"arnd@linaro.org" <arnd@linaro.org>,
"xie.baoyou@zte.com.cn" <xie.baoyou@zte.com.cn>
Subject: Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible
Date: Thu, 1 Sep 2016 10:59:01 +0000 [thread overview]
Message-ID: <D3EE07A2.24D3C%nilesh.javali@qlogic.com> (raw)
In-Reply-To: <1472467611-8574-1-git-send-email-baoyou.xie@linaro.org>
On 29/08/16 4:16 PM, "Baoyou Xie" <baoyou.xie@linaro.org> wrote:
>We get 1 warning when build kernel with W=1:
>drivers/scsi/qla4xxx/ql4_nx.c:1846:10: warning: no previous prototype for
>'ql4_84xx_ipmdio_rd_reg' [-Wmissing-prototypes]
>
>In fact, this function is only used in the file in which it is
>declared and don't need a declaration, but can be made static.
>so this patch marks this function with 'static'.
>
>Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>---
> drivers/scsi/qla4xxx/ql4_nx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
>index ae87d6c..06ddd13 100644
>--- a/drivers/scsi/qla4xxx/ql4_nx.c
>+++ b/drivers/scsi/qla4xxx/ql4_nx.c
>@@ -1843,7 +1843,7 @@ static uint32_t ql4_84xx_poll_wait_for_ready(struct
>scsi_qla_host *ha,
> return rval;
> }
>
>-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1,
>+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha,
>uint32_t addr1,
> uint32_t addr3, uint32_t mask, uint32_t addr,
> uint32_t *data_ptr)
> {
>--
>2.7.4
Acked-by: Nilesh Javali <nilesh.javali@qlogic.com>
next prev parent reply other threads:[~2016-09-01 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 10:46 [PATCH] [SCSI] qla4xxx: mark symbols static where possible Baoyou Xie
2016-09-01 10:59 ` Nilesh Javali [this message]
2016-09-02 10:08 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D3EE07A2.24D3C%nilesh.javali@qlogic.com \
--to=nilesh.javali@qlogic.com \
--cc=QLogic-Storage-Upstream@qlogic.com \
--cc=arnd@linaro.org \
--cc=baoyou.xie@linaro.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).