From: mike@it-loops.com
To: Kai Makisara <Kai.Makisara@kolumbus.fi>
Cc: Joachim Feise <jfeise@ics.uci.edu>,
linux-scsi@vger.kernel.org, Michael Guntsche <mike@it-loops.com>,
Andrew Morton <akpm@osdl.org>,
"Justin T. Gibbs" <gibbs@scsiguy.com>,
Frank Pieczynski <pieczy@web.de>, Jens Axboe <axboe@suse.de>
Subject: Re: PROBLEM: 2.6.3 hangs when writing to scsi-dvd
Date: Mon, 23 Feb 2004 14:46:23 +0100 [thread overview]
Message-ID: <E1AvGPf-0005BY-00@localhost> (raw)
In-Reply-To: <Pine.LNX.4.58.0402231329480.1749@kai.makisara.local>
Kai Makisara writes:
>> --- linux-2.6.3/drivers/scsi/scsi_lib.c.orig 2004-02-17 19:57:57.000000000 -0800
>> +++ linux-2.6.3/drivers/scsi/scsi_lib.c 2004-02-20 13:52:46.000000000 -0800
>> @@ -1292,7 +1292,7 @@
>> * host adapters. A host driver can alter this mask in its
>> * slave_alloc() or slave_configure() callback if necessary.
>> */
>> - blk_queue_dma_alignment(q, (8 - 1));
>> + /* blk_queue_dma_alignment(q, (8 - 1)); */
>>
>> if (!shost->use_clustering)
>> clear_bit(QUEUE_FLAG_CLUSTER, &q->queue_flags);
>>
>> But without knowing what this particular line does, it is impossible for me
>> to say if commenting out the line is the right thing to do.
>>
> This line has has several duties. For me, it sets the alignment constaint
> used by st for deciding whether to use direct i/o or internal buffer. For
> other people more important is that it is used for similar purpose in
> linux/fs/bio.c. The beginning of __bio_map_user contains the following:
<snip>
Thanks for the info. Since my problem occured with an external firewire
burner I asked Ben Collins (maintainer of the sbp2 driver) about it this
weekend.
The USB2 port of the burner worked without any problems, so we took a look
at the USB mass-storage driver.
It calls blk_queue_dma_alignment(q, (512 - 1)) in slave_configure.
We decided to add a slave_configure in sbp2 too and it works now.
I know that this doesn't solve the problem for other users, but it seems to
be the fastest solution for devices connected via sbp2.
Michael
next prev parent reply other threads:[~2004-02-23 13:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-19 19:47 PROBLEM: 2.6.3 hangs when writing to scsi-dvd Joachim Feise
2004-02-20 22:13 ` Joachim Feise
2004-02-23 11:52 ` Kai Makisara
2004-02-23 13:26 ` Jens Axboe
2004-02-23 14:22 ` Kai Makisara
2004-02-23 14:25 ` Jens Axboe
2004-02-23 18:21 ` Frank Pieczynski
2004-02-23 19:05 ` Jens Axboe
2004-02-24 7:18 ` Joachim Feise
2004-02-23 13:46 ` mike [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-02-21 10:25 Michael Guntsche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1AvGPf-0005BY-00@localhost \
--to=mike@it-loops.com \
--cc=Kai.Makisara@kolumbus.fi \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=gibbs@scsiguy.com \
--cc=jfeise@ics.uci.edu \
--cc=linux-scsi@vger.kernel.org \
--cc=pieczy@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox