Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "NickCheng" <nick.cheng@areca.com.tw>
To: linux-scsi@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, jejb@kernel.org,
	??? <ching2048@areca.com.tw>
Subject: [PATCH 3/5]  arcmsr: Support MSI and MSI-X
Date: Fri, 8 Feb 2013 14:02:46 +0800	[thread overview]
Message-ID: <F09D285F14A941CA929D3AAC3992BA8C@arecaaebe11fae> (raw)

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]

From: Nick Cheng <nick.cheng@areca.com.tw>

Support MSI or MSI-X for whole series of RAID controllers. Meanwhile correct the register access as iowrite32/ioread32 
Signed-off-by: Nick Cheng <nick.cheng@areca.com.tw>
---

[-- Attachment #2: checkpatch3 --]
[-- Type: application/octet-stream, Size: 646 bytes --]

WARNING: printk() should include KERN_ facility level
#42: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:885:
+				printk("arcmsr%d: request_irq = %d failed!\n",

WARNING: braces {} are not necessary for any arm of this statement
#71: FILE: drivers/scsi/arcmsr/arcmsr_hba.c:926:
+	if (acb->acb_flags & ACB_F_MSI_ENABLED) {
[...]
+	} else if (acb->acb_flags & ACB_F_MSIX_ENABLED) {
[...]

ERROR: Missing Signed-off-by: line(s)

total: 1 errors, 2 warnings, 114 lines checked

../patch3 has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.

             reply	other threads:[~2013-02-08  6:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-08  6:02 NickCheng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2013-02-08  6:04 [PATCH 3/5] arcmsr: Support MSI and MSI-X NickCheng
2013-02-06  8:36 NickCheng
2012-12-04 11:59 NickCheng
2012-11-16 11:55 NickCheng
2012-11-15  7:25 NickCheng
2012-10-12  9:08 NickCheng
2012-10-03 12:40 NickCheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F09D285F14A941CA929D3AAC3992BA8C@arecaaebe11fae \
    --to=nick.cheng@areca.com.tw \
    --cc=ching2048@areca.com.tw \
    --cc=jejb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox