From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Damien Le Moal <Damien.LeMoal@wdc.com>
Cc: linux-scsi@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH v2 1/3] scsi: Cleanup scsi_noretry_cmd()
Date: Thu, 10 Sep 2020 10:45:48 -0500 [thread overview]
Message-ID: <F946D669-CE85-4383-8EB2-7C92CE4EEAB9@oracle.com> (raw)
In-Reply-To: <20200910074843.217661-2-damien.lemoal@wdc.com>
> On Sep 10, 2020, at 2:48 AM, Damien Le Moal <Damien.LeMoal@wdc.com> wrote:
>
> No need for else after return.
>
> Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
> ---
> drivers/scsi/scsi_error.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c
> index 927b1e641842..5f3726abed78 100644
> --- a/drivers/scsi/scsi_error.c
> +++ b/drivers/scsi/scsi_error.c
> @@ -1755,8 +1755,8 @@ int scsi_noretry_cmd(struct scsi_cmnd *scmd)
> if (scmd->request->cmd_flags & REQ_FAILFAST_DEV ||
> blk_rq_is_passthrough(scmd->request))
> return 1;
> - else
> - return 0;
> +
> + return 0;
> }
>
> /**
> --
> 2.26.2
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2020-09-10 21:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 7:48 [PATCH v2 0/3] Improve error handling Damien Le Moal
2020-09-10 7:48 ` [PATCH v2 1/3] scsi: Cleanup scsi_noretry_cmd() Damien Le Moal
2020-09-10 8:05 ` Johannes Thumshirn
2020-09-10 15:45 ` Himanshu Madhani [this message]
2020-09-10 7:48 ` [PATCH v2 2/3] scsi: update additional sense codes list Damien Le Moal
2020-09-10 8:08 ` Johannes Thumshirn
2020-09-10 15:46 ` Himanshu Madhani
2020-09-10 7:48 ` [PATCH v2 3/3] scsi: handle zone resources errors Damien Le Moal
2020-09-10 15:46 ` Himanshu Madhani
2020-09-16 0:29 ` [PATCH v2 0/3] Improve error handling Martin K. Petersen
2020-09-16 1:11 ` Damien Le Moal
2020-09-22 3:56 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F946D669-CE85-4383-8EB2-7C92CE4EEAB9@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=Damien.LeMoal@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox