From: Thorsten Blum <thorsten.blum@linux.dev>
To: Kees Cook <kees@kernel.org>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
linux-hardening@vger.kernel.org, linux-scsi@vger.kernel.org,
target-devel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: target: Replace deprecated strncpy() with strscpy()
Date: Sun, 2 Mar 2025 12:41:04 +0100 [thread overview]
Message-ID: <FB0D4471-9413-4E7D-BFC0-246AD3F54C60@linux.dev> (raw)
In-Reply-To: <202502281204.CE15A6BA35@keescook>
On 28. Feb 2025, at 21:10, Kees Cook wrote:
> On Wed, Feb 26, 2025 at 01:10:03PM +0100, Thorsten Blum wrote:
>> Since strncpy() is deprecated for NUL-terminated destination buffers,
>> use strscpy() instead.
>>
>> Compile-tested only.
>>
>> Link: https://github.com/KSPP/linux/issues/90
>> Cc: linux-hardening@vger.kernel.org
>> Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>> ---
>
> When doing strncpy() to strscpy() conversions, please include details
> of your analysis for several things:
>
> - why is it safe to be NUL-terminated?
> - why is NUL padding needed/not needed?
> - why is the maximum length argument correct?
Yes, I'll try to describe it better.
> While you're in this file, though, can you replace the other strncpy
> that is used in target_init_dbroot() also?
Ah, I missed this one and will submit a v2 soon.
Thanks,
Thorsten
prev parent reply other threads:[~2025-03-02 11:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-26 12:10 [PATCH] scsi: target: Replace deprecated strncpy() with strscpy() Thorsten Blum
2025-02-28 20:10 ` Kees Cook
2025-03-02 11:41 ` Thorsten Blum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FB0D4471-9413-4E7D-BFC0-246AD3F54C60@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox