From: Ingo Molnar <mingo@redhat.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] remove name length check in a workqueue
Date: Wed, 10 Aug 2005 10:45:03 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.58.0508101044110.31617@devserv.devel.redhat.com> (raw)
In-Reply-To: <1123683544.5093.4.camel@mulgrave>
yeah ... cannot remember why i have done it originally :-|
Acked-by: Ingo Molnar <mingo@redhat.com>
Ingo
On Wed, 10 Aug 2005, James Bottomley wrote:
> Ingo,
>
> This has been in the workqueue code in day one, for no real reason that
> I can see. We just tripped over it in SCSI because the fibre channel
> transport class creates one workqueue per host with the name scsi_wq_%d
> which trips this after we get to 100. Unfortunately we just came across
> someone with > 100 host adapters ...
>
> I think the solution is just to get rid of the artificial limit.
>
> James
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -308,8 +308,6 @@ struct workqueue_struct *__create_workqu
> struct workqueue_struct *wq;
> struct task_struct *p;
>
> - BUG_ON(strlen(name) > 10);
> -
> wq = kmalloc(sizeof(*wq), GFP_KERNEL);
> if (!wq)
> return NULL;
>
>
next prev parent reply other threads:[~2005-08-10 14:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-10 14:19 [PATCH] remove name length check in a workqueue James Bottomley
2005-08-10 14:45 ` Ingo Molnar [this message]
2005-08-10 17:05 ` Andrew Morton
2005-08-10 17:24 ` James Bottomley
2005-08-10 17:37 ` Andrew Morton
2005-08-10 17:54 ` James Bottomley
2005-08-10 18:27 ` Andrew Morton
2005-08-11 14:37 ` Simon Derr
2005-08-11 16:22 ` Coywolf Qi Hunt
2005-08-10 18:49 ` Frederic TEMPORELLI - astek
-- strict thread matches above, loose matches on Subject: below --
2005-08-11 18:48 Andreas Herrmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0508101044110.31617@devserv.devel.redhat.com \
--to=mingo@redhat.com \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox