Linux SCSI subsystem development
 help / color / mirror / Atom feed
From: "Randy.Dunlap" <rdunlap@xenotime.net>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	linux-scsi@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH 6/8] kernel-doc: fix scsi docbook
Date: Sun, 3 Feb 2008 20:22:30 -0800 (PST)	[thread overview]
Message-ID: <Pine.LNX.4.64.0802032014450.2108@shark.he.net> (raw)
In-Reply-To: <1202085030.3318.132.camel@localhost.localdomain>

On Sun, 3 Feb 2008, James Bottomley wrote:

> On Sun, 2008-02-03 at 15:06 -0800, Randy.Dunlap wrote:
> > From: Randy Dunlap <randy.dunlap@oracle.com>
> > 
> > Add missing function parameter descriptions.
> > Make function short description fit on one line as required.
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> > ---
> >   drivers/scsi/scsi.c |    5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> > 
> > --- linux-2.6.24-git12.orig/drivers/scsi/scsi.c
> > +++ linux-2.6.24-git12/drivers/scsi/scsi.c
> > @@ -969,9 +969,10 @@ void starget_for_each_device(struct scsi
> >   EXPORT_SYMBOL(starget_for_each_device);
> > 
> >   /**
> > - * __starget_for_each_device  -  helper to walk all devices of a target
> > - *				 (UNLOCKED)
> > + * __starget_for_each_device - helper to walk all devices of a target (UNLOCKED)
> >    * @starget:	target whose devices we want to iterate over.
> > + * @data:	parameter for callback @fn()
> > + * @fn:		callback function that is invoked for each device
> >    *
> >    * This traverses over each device of @starget.  It does _not_
> >    * take a reference on the scsi_device, so the whole loop must be
> ^^^^^
> I have this, but it's a bit mysterious: something added an extra space
> to the non +/- lines making the patch reject.  I pulled it out by hand
> and it applied fine.

Thanks.  I think that I had a pine config error that caused the problem.
Should be fixed now.

-- 
~Randy

      reply	other threads:[~2008-02-04  4:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-03 23:06 [PATCH 6/8] kernel-doc: fix scsi docbook Randy.Dunlap
2008-02-04  0:30 ` James Bottomley
2008-02-04  4:22   ` Randy.Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.0802032014450.2108@shark.he.net \
    --to=rdunlap@xenotime.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox