Re: [PATCH] new mac_scsi driver

James Bottomley
2008-04-24T21:33:32Z

On Thu, 2008-04-24 at 23:08 +0200, Geert Uytterhoeven wrote:
> On Thu, 24 Apr 2008, Finn Thain wrote:
> > Replace the mac_esp driver with a new one based on the esp_scsi core.
> >
> > For esp_scsi: add support for sync transfers for the PIO mode, add a new
> > esp_driver_ops method to get the maximum dma transfer size (like the old
> > NCR53C9x driver), and some cleanups.
>
> Thanks!
>
> I added this patch to my series, after fixing the few checkpatch.pl issues and
> adding a test for MACH_IS_MAC() to esp_mac_probe().

I got the tabs and spaces thing. I'm not too concerned about the
assignment in conditional, but I'm happy to go whichever way the author
does.

Could you repost please because I already have this queued, so I need a
replacement (assuming everyone agrees). There are other issues with the
driver (like the dma_length_limit stuff which looks like it should
really by fixed using the block layer segment boundary/segment length
limits, but that's more esp generic than mac_esp specific) which I
planned to look into after it was merged.

Thanks,

James