public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia@diku.dk>
To: "James E.J. Bottomley" <James.Bottomley@suse.de>,
	linux-scsi@vger.kernel.org
Cc: joe@perches.com
Subject: question about drivers/scsi/scsi_transport_fc.c
Date: Sat, 28 Aug 2010 19:11:12 +0200 (CEST)	[thread overview]
Message-ID: <Pine.LNX.4.64.1008281908150.13508@ask.diku.dk> (raw)

The function fc_bsg_goose_queue in the file drivers/scsi/scsi_transport_fc.c
contains the following code:

        flagset = test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags) &&
                  !test_bit(QUEUE_FLAG_REENTER, &rport->rqst_q->queue_flags);

I have the impression that this is always 0.  QUEUE_FLAG_REENTER is 
defined with quite a lot of other constants, so I don't really have a 
guess as to what was intended.

thanks,
julia

             reply	other threads:[~2010-08-28 17:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-28 17:11 Julia Lawall [this message]
2010-09-02 10:53 ` question about drivers/scsi/scsi_transport_fc.c Christof Schmitt
2010-09-02 13:39   ` Hannes Reinecke
2010-09-02 14:28     ` Christof Schmitt
2010-09-02 15:01       ` [PATCH] scsi: Remove QUEUE_FLAG_REENTER from SCSI code Christof Schmitt
2010-09-27  7:58         ` James Bottomley
2010-10-04 13:47           ` Christof Schmitt
2010-10-05  9:00             ` [PATCH v2] " Christof Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.64.1008281908150.13508@ask.diku.dk \
    --to=julia@diku.dk \
    --cc=James.Bottomley@suse.de \
    --cc=joe@perches.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox