Re: [PATCH] scsi: libsas and users: Remove notifier indirection

Ahmed S. Darwish
2021-01-11T17:53:11Z

On Mon, Jan 11, 2021 at 05:44:17PM +0000, John Garry wrote:
> On 11/01/2021 17:41, Ahmed S. Darwish wrote:
> > On Tue, Jan 12, 2021 at 01:28:32AM +0800, John Garry wrote:
> > ...
> > > index a920eced92ec..6a51abdc59ae 100644
> > > --- a/drivers/scsi/mvsas/mv_sas.c
> > > +++ b/drivers/scsi/mvsas/mv_sas.c
> > > @@ -230,7 +230,7 @@ static void mvs_bytes_dmaed(struct mvs_info *mvi, int i)
> > > }
> > >
> > > sas_ha = mvi->sas;
> > > - sas_ha->notify_phy_event(sas_phy, PHYE_OOB_DONE);
> > > + sas_notify_phy_event(sas_phy, PHYE_OOB_DONE);
> > >
> >
> > Minor point: "sas_ha" is now not used anywhere; it should be removed.
> > .
> >
>
> ah, yes, it can be removed.
>

Similarly for drivers/scsi/pm8001/pm8001_sas.c.

(Just discovering these while integrating your patch at the top of my
series).

> BTW, on separate topic, did intel-linux-scu@intel.com bounce for you?
>

Yup :)

--
Ahmed S. Darwish
Linutronix GmbH