public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Avri Altman <Avri.Altman@wdc.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"kernel-team@android.com" <kernel-team@android.com>,
	"cang@codeaurora.org" <cang@codeaurora.org>,
	"alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
	"bvanassche@acm.org" <bvanassche@acm.org>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: Re: [PATCH v2] scsi: ufs: WB is not allowed in RPMB_LUN
Date: Mon, 11 Jan 2021 01:59:01 -0800	[thread overview]
Message-ID: <X/whZfoRQvEncfUS@google.com> (raw)
In-Reply-To: <DM6PR04MB657566F1BB8C808EFBF9FBB9FCAB0@DM6PR04MB6575.namprd04.prod.outlook.com>

On 01/11, Avri Altman wrote:
> >  static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,
> > -               u8 lun)
> > +               u8 lun, u8 param_offset)
> >  {
> >         if (!dev_info || !dev_info->max_lu_supported) {
> >                 pr_err("Max General LU supported by UFS isn't initialized\n");
> >                 return false;
> >         }
> > -
> > +       /* WB is not allowed in RPMB_WLUN */
> /* wb is only allowed to either a sha*/
> > +       if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
> > +               return lun < dev_info->max_lu_supported;
> I think here you should use UFS_UPIU_MAX_WB_LUN_ID and not dev_info->max_lu_supported.

Ok, sending v3.

> 
> Thanks,
> Avri

      reply	other threads:[~2021-01-11 10:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-11  8:47 [PATCH v2] scsi: ufs: WB is not allowed in RPMB_LUN Jaegeuk Kim
2021-01-11  9:20 ` Avri Altman
2021-01-11  9:59   ` Jaegeuk Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/whZfoRQvEncfUS@google.com \
    --to=jaegeuk@kernel.org \
    --cc=Avri.Altman@wdc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=bvanassche@acm.org \
    --cc=cang@codeaurora.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox