From: Greg KH <greg@kroah.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Subbu Seetharaman <subbu.seetharaman@broadcom.com>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
James.Bottomley@suse.de,
jayamohank@hdredirect-lb5-1afb6e2973825a56.elb.us-east-1.amazonaws.com,
jejb@linux.ibm.com, jitendra.bhivare@broadcom.com,
kernel-janitors@vger.kernel.org, ketan.mukadam@broadcom.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()"
Date: Thu, 3 Dec 2020 19:25:05 +0100 [thread overview]
Message-ID: <X8ktgeCVhGPw4wnW@kroah.com> (raw)
In-Reply-To: <X8jXkt6eThjyVP1v@mwanda>
On Thu, Dec 03, 2020 at 03:18:26PM +0300, Dan Carpenter wrote:
> My patch caused kernel Oopses and delays in boot. Revert it.
>
> The problem was that I moved the "mem->dma = paddr;" before the call to
> be_fill_queue(). But the first thing that the be_fill_queue() function
> does is memset the whole struct to zero which overwrites the assignment.
>
> Fixes: 38b2db564d9a ("scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs()")
> Reported-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Can someone please add:
Cc: stable <stable@vger.kernel.org>
to this so we know to pick it up quickly there?
thanks,
greg k-h
next prev parent reply other threads:[~2020-12-03 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-28 9:13 [PATCH] scsi: be2iscsi: Fix a theoretical leak in beiscsi_create_eqs() Dan Carpenter
2020-10-07 3:47 ` Martin K. Petersen
2020-12-03 10:10 ` Thomas Lamprecht
2020-12-03 12:03 ` Dan Carpenter
2020-12-03 12:18 ` [PATCH] scsi: be2iscsi: revert "Fix a theoretical leak in beiscsi_create_eqs()" Dan Carpenter
2020-12-03 18:25 ` Greg KH [this message]
2020-12-03 20:45 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X8ktgeCVhGPw4wnW@kroah.com \
--to=greg@kroah.com \
--cc=James.Bottomley@suse.de \
--cc=dan.carpenter@oracle.com \
--cc=jayamohank@hdredirect-lb5-1afb6e2973825a56.elb.us-east-1.amazonaws.com \
--cc=jejb@linux.ibm.com \
--cc=jitendra.bhivare@broadcom.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=ketan.mukadam@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
--cc=subbu.seetharaman@broadcom.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox