public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrien Thierry <athierry@redhat.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
	Avri Altman <avri.altman@wdc.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: probe hba and add lus synchronously
Date: Fri, 3 Feb 2023 16:12:42 -0500	[thread overview]
Message-ID: <Y914yu4rSqvpSoRZ@fedora> (raw)
In-Reply-To: <90e4fb52-6b09-00d9-7591-7140b859ed15@acm.org>

> Are all UFS users using the devfreq framework? Otherwise this sounds good to me.

The warning originates from the UFS core :

ufshcd_init() -> ufshcd_async_scan() -> ufshcd_add_lus() ->
ufshcd_devfreq_init()

ufshcd_devfreq_init() is called as long as
ufshcd_is_clkscaling_supported(hba) returns true, i.e.
UFSHCD_CAP_CLK_SCALING is set. This is not the case for all UFS users, but
it could potentially be if they start supporting clock scaling. Moreover,
in the current Kconfigs, DEVFREQ_GOV_SIMPLE_ONDEMAND is already selected
when SCSI_UFSHCD is enabled. We just need to force it to be builtin.

Best,

Adrien


  reply	other threads:[~2023-02-03 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-02 18:21 [PATCH] scsi: ufs: probe hba and add lus synchronously Adrien Thierry
2023-02-02 18:27 ` Bart Van Assche
2023-02-03 20:40   ` Adrien Thierry
2023-02-03 20:53     ` Bart Van Assche
2023-02-03 21:12       ` Adrien Thierry [this message]
2023-02-07 22:54         ` Adrien Thierry
2023-02-07 23:11           ` Bart Van Assche
2023-02-15 13:52             ` Adrien Thierry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y914yu4rSqvpSoRZ@fedora \
    --to=athierry@redhat.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bvanassche@acm.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox