RE: [PATCH 1/8] scsi: ufshpb: Cache HPB Control mode on init

Avri Altman
2021-01-31T07:19:00Z

> On Sun, Jan 31, 2021 at 07:08:00AM +0000, Avri Altman wrote:
> > > >
> > > > +static enum UFSHPB_MODE ufshpb_mode;
> > >
> > > How are you allowed to have a single variable for a device-specific
> > > thing? What happens when you have two controllers or disks or whatever
> > > you are binding to here? How does this work at all?
> > >
> > > This should be per-device, right?
> > Right. Done.
> >
> > Not being bickering, AFAIK, there aren't, nor will be in the foreseen future,
> any multi-ufs-hosts designs.
>
> Why not? What prevents someone from putting 2 PCI ufs host controllers
> in a system tomorrow?
>
> > There were some talks in the past about ufs cards, but this is officially off
> the table.
>
> Never say never :)
>
> Seriously, how can you somehow ensure that a random manufacturer will
> not do this?
Better let the platform vendors answer this.

As for your comment - you are obviously right - I will fix this.

Thanks,
Avri