From: Greg KH <gregkh@linuxfoundation.org>
To: Avri Altman <avri.altman@wdc.com>
Cc: "James E . J . Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Bart Van Assche <bvanassche@acm.org>,
yongmyung lee <ymhungry.lee@samsung.com>,
Daejun Park <daejun7.park@samsung.com>,
alim.akhtar@samsung.com, asutoshd@codeaurora.org,
Zang Leigang <zangleigang@hisilicon.com>,
Avi Shchislowski <avi.shchislowski@wdc.com>,
Bean Huo <beanhuo@micron.com>,
cang@codeaurora.org, stanley.chu@mediatek.com
Subject: Re: [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu
Date: Tue, 2 Feb 2021 12:13:50 +0100 [thread overview]
Message-ID: <YBkz7m7uMP4iJ/qn@kroah.com> (raw)
In-Reply-To: <20210202083007.104050-3-avri.altman@wdc.com>
On Tue, Feb 02, 2021 at 10:30:00AM +0200, Avri Altman wrote:
> diff --git a/drivers/scsi/ufs/ufshpb.h b/drivers/scsi/ufs/ufshpb.h
> index afeb6365daf8..5ec4023db74d 100644
> --- a/drivers/scsi/ufs/ufshpb.h
> +++ b/drivers/scsi/ufs/ufshpb.h
> @@ -48,6 +48,11 @@ enum UFSHPB_MODE {
> HPB_DEVICE_CONTROL,
> };
>
> +enum HPB_RGN_FLAGS {
> + RGN_FLAG_UPDATE = 0,
> + RGN_FLAG_DIRTY,
> +};
> +
> enum UFSHPB_STATE {
> HPB_PRESENT = 1,
> HPB_SUSPEND,
> @@ -109,6 +114,7 @@ struct ufshpb_region {
>
> /* below information is used by lru */
> struct list_head list_lru_rgn;
> + unsigned long rgn_flags;
Why an unsigned long for a simple enumerated type? And why not make
this "type safe" by explicitly saying this is an enumerated type
variable?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-02 11:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-02 8:29 [PATCH v2 0/9] Add Host control mode to HPB Avri Altman
2021-02-02 8:29 ` [PATCH v2 1/9] scsi: ufshpb: Cache HPB Control mode on init Avri Altman
2021-02-02 8:30 ` [PATCH v2 2/9] scsi: ufshpb: Add host control mode support to rsp_upiu Avri Altman
2021-02-02 11:13 ` Greg KH [this message]
2021-02-02 11:24 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:54 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 3/9] scsi: ufshpb: Add region's reads counter Avri Altman
2021-02-02 11:15 ` Greg KH
2021-02-02 11:23 ` Avri Altman
2021-02-02 11:51 ` Greg KH
2021-02-02 11:16 ` Greg KH
2021-02-02 11:22 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 4/9] scsi: ufshpb: Make eviction depends on region's reads Avri Altman
2021-02-02 8:30 ` [PATCH v2 5/9] scsi: ufshpb: Region inactivation in host mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 6/9] scsi: ufshpb: Add hpb dev reset response Avri Altman
2021-02-08 6:34 ` Can Guo
2021-02-08 7:50 ` Avri Altman
2021-02-02 8:30 ` [PATCH v2 7/9] scsi: ufshpb: Add "Cold" regions timer Avri Altman
2021-02-02 8:30 ` [PATCH v2 8/9] scsi: ufshpb: Add support for host control mode Avri Altman
2021-02-02 8:30 ` [PATCH v2 9/9] scsi: ufshpb: Make host mode parameters configurable Avri Altman
2021-02-02 11:17 ` Greg KH
2021-02-02 11:21 ` Avri Altman
2021-02-04 0:48 ` Daejun Park
2021-02-02 11:18 ` Greg KH
2021-02-02 11:20 ` Avri Altman
2021-02-05 11:36 ` [PATCH v2 0/9] Add Host control mode to HPB Bean Huo
2021-02-05 11:43 ` Bean Huo
2021-02-07 14:07 ` Avri Altman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YBkz7m7uMP4iJ/qn@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alim.akhtar@samsung.com \
--cc=asutoshd@codeaurora.org \
--cc=avi.shchislowski@wdc.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=daejun7.park@samsung.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
--cc=ymhungry.lee@samsung.com \
--cc=zangleigang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox