Re: [PATCH] scsi: snic: debugfs: remove local storage of debugfs files

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, May 18, 2021 at 06:16:25PM +0200, Greg Kroah-Hartman wrote:
> There is no need to keep the dentry around for the debugfs trace files,
> as we can just look it up when we want to remove it later on.  Simplify
> the structure by removing the dentries and relying on debugfs to find
> the dentry to remove when we want to.
> 
> By doing this change, we remove the last in-kernel user that was storing
> the result of debugfs_create_bool(), so that api can be cleaned up.
> 
> Cc: Karan Tilak Kumar <kartilak@cisco.com>
> Cc: Sesidhar Baddela <sebaddel@cisco.com>
> Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
> Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
> Cc: linux-scsi@vger.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  drivers/scsi/snic/snic_debugfs.c | 23 +++++++++--------------
>  drivers/scsi/snic/snic_trc.h     |  3 ---
>  2 files changed, 9 insertions(+), 17 deletions(-)

I can take this through my debugfs tree so I can clean up the
debugfs_create_bool() api if no one objects.

thanks,

greg k-h