From: David Sebek <dasebek@gmail.com>
To: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org
Cc: dasebek@gmail.com
Subject: [PATCH] scsi: Set BLIST_TRY_VPD_PAGES for WD Black P10 external HDD
Date: Mon, 31 May 2021 17:22:13 -0400 [thread overview]
Message-ID: <YLVThaYJ0cXzy57D@david-pc> (raw)
The 5TB 2.5-inch WD Black P10 external USB hard drive seems
to use SMR technology. It supports TRIM via the unmap operation.
Maybe because it is marketed as a drive for gaming that is
compatible with PlayStation, Xbox, PC and Mac, it does not
support UASP protocol but uses bulk-only transport.
Therefore, Linux does not attempt to read the VPD and does
not enable TRIM by default. (Currently, there is a bug and
Linux incorrectly enables a writesame_16 TRIM operation on
the drive and does not change it to the correct unmap TRIM
operation because it does not attempt to read the info from
the VPD. I already submitted a patch for that bug.)
This patch adds this drive to the scsi_static_device_list
with a BLIST_TRY_VPD_PAGES flag. Although there are comments
in the code indicating that this list is deprecated and that
'echo "WD:Game Drive:0x10000400" > /proc/scsi/device_info'
should be used instead, I haven't found a better place to
persist this information. Moreover, the list already contains
a similar entry for the SanDisk Cruzer Blade USB flash drive.
Signed-off-by: David Sebek <dasebek@gmail.com>
---
drivers/scsi/scsi_devinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index d92cec12454c..3ed558c168be 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -256,6 +256,7 @@ static struct {
{"WangDAT", "Model 2600", "01.7", BLIST_SELECT_NO_ATN},
{"WangDAT", "Model 3200", "02.2", BLIST_SELECT_NO_ATN},
{"WangDAT", "Model 1300", "02.4", BLIST_SELECT_NO_ATN},
+ {"WD", "Game Drive", NULL, BLIST_TRY_VPD_PAGES | BLIST_INQUIRY_36},
{"WDC WD25", "00JB-00FUA0", NULL, BLIST_NOREPORTLUN},
{"XYRATEX", "RS", "*", BLIST_SPARSELUN | BLIST_LARGELUN},
{"Zzyzx", "RocketStor 500S", NULL, BLIST_SPARSELUN},
--
2.31.1
next reply other threads:[~2021-05-31 21:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 21:22 David Sebek [this message]
2021-06-02 2:53 ` [PATCH] scsi: Set BLIST_TRY_VPD_PAGES for WD Black P10 external HDD Martin K. Petersen
2021-06-02 2:57 ` Martin K. Petersen
2021-06-02 15:26 ` David Sebek
2021-06-11 2:10 ` Martin K. Petersen
2021-06-17 2:19 ` David Sebek
2021-06-19 1:55 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLVThaYJ0cXzy57D@david-pc \
--to=dasebek@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox