From: Christoph Hellwig <hch@infradead.org>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org, torvalds@linux-foundation.org,
muneendra.kumar@broadcom.com
Subject: Re: [PATCH] scsi: blkcg: Fix application ID config options
Date: Sun, 4 Jul 2021 09:45:08 +0100 [thread overview]
Message-ID: <YOF1FBdMd65S6L57@infradead.org> (raw)
In-Reply-To: <20210703155833.3267-1-martin.petersen@oracle.com>
On Sat, Jul 03, 2021 at 11:58:33AM -0400, Martin K. Petersen wrote:
> - depends on BLK_CGROUP=y
> + depends on BLK_CGROUP=y && NVME_FC
BLK_CGROUP is a bool, so I think this can simply be:
depends on BLK_CGROUP && NVME_FC
Otherwise this looks much better:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2021-07-04 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-03 15:58 [PATCH] scsi: blkcg: Fix application ID config options Martin K. Petersen
2021-07-04 8:45 ` Christoph Hellwig [this message]
2021-07-04 18:46 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOF1FBdMd65S6L57@infradead.org \
--to=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=muneendra.kumar@broadcom.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox