From: Sasha Levin <sashal@kernel.org>
To: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
"Martin K . Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org,
Kernel Janitors <kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages
Date: Wed, 21 Jul 2021 06:42:49 -0400 [thread overview]
Message-ID: <YPf6KXaz+LLnC0vi@sashalap> (raw)
In-Reply-To: <615a1135-bbb0-0384-8499-716f26fba08a@wanadoo.fr>
On Fri, Jul 16, 2021 at 09:22:43PM +0200, Marion & Christophe JAILLET wrote:
>
>Le 14/07/2021 à 21:48, Sasha Levin a écrit :
>>From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>
>>[ Upstream commit c7fa2c855e892721bafafdf6393342c000e0ef77 ]
>>
>>Fix a few style issues reported by checkpatch.pl:
>>
>> - Avoid duplicated word in comment.
>>
>> - Add missing space in messages.
>>
>> - Unneeded continuation line character.
>>
>> - Unneeded extra spaces.
>>
>> - Unneeded log message after memory allocation failure.
>>
>>Link: https://lore.kernel.org/r/8cb62f0eb96ec7ce7a73fe97cb4490dd5121ecff.1623482155.git.christophe.jaillet@wanadoo.fr
>>Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
>>Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
>>Signed-off-by: Sasha Levin <sashal@kernel.org>
>
>Hi,
>
>I always appreciate to have some patches backported, but in this
>particular case, I wonder what is the rational to backport up to 4.9
>some checkpatch warning about log message?
>
>Keeping code aligned to ease other future backport?
>
>I thought that the rule for backport was that it needed to fix a real
>issue (and sometimes a real 'potential' issue)
I think that I brought it in as a dependency for something else, but I
don't see what it was. I'll drop it then, thanks!
--
Thanks,
Sasha
prev parent reply other threads:[~2021-07-21 10:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210714194806.55962-1-sashal@kernel.org>
2021-07-14 19:48 ` [PATCH AUTOSEL 4.9 16/18] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8 Sasha Levin
2021-07-14 19:48 ` [PATCH AUTOSEL 4.9 17/18] scsi: be2iscsi: Fix some missing space in some messages Sasha Levin
2021-07-16 19:22 ` Marion & Christophe JAILLET
2021-07-21 10:42 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPf6KXaz+LLnC0vi@sashalap \
--to=sashal@kernel.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox