From: Christoph Hellwig <hch@infradead.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bvanassche@acm.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Jaegeuk Kim <jaegeuk@kernel.org>,
linux-scsi@vger.kernel.org,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
Can Guo <cang@codeaurora.org>, Bean Huo <beanhuo@micron.com>,
Stanley Chu <stanley.chu@mediatek.com>,
Asutosh Das <asutoshd@codeaurora.org>,
Hannes Reinecke <hare@suse.com>,
John Garry <john.garry@huawei.com>
Subject: Re: [PATCH 2/2] scsi: ufs: Fix a deadlock in the error handler
Date: Wed, 3 Nov 2021 09:33:56 -0700 [thread overview]
Message-ID: <YYK59D+M5w4FSoo0@infradead.org> (raw)
In-Reply-To: <19b8e555-d12f-9bf5-91c6-d3c5f849e72c@intel.com>
On Wed, Nov 03, 2021 at 10:37:30AM +0200, Adrian Hunter wrote:
> The UFS driver does not issue device commands to the block layer.
> blk_get_request() is used only to get a free slot.
That is indeed the case for the code touched here, but not in general:
ch@brick:~/work/linux$ git-grep blk_execute_rq drivers/scsi/ufs/
drivers/scsi/ufs/ufshcd.c: blk_execute_rq_nowait(/*bd_disk=*/NULL, req, /*at_head=*/true,
drivers/scsi/ufs/ufshpb.c: blk_execute_rq_nowait(NULL, req, 1, ufshpb_umap_req_compl_fn);
drivers/scsi/ufs/ufshpb.c: blk_execute_rq_nowait(NULL, req, 1, ufshpb_map_req_compl_fn);
next prev parent reply other threads:[~2021-11-03 16:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 0:05 [PATCH 0/2] Fix a deadlock in the UFS error handler Bart Van Assche
2021-11-03 0:05 ` [PATCH 1/2] scsi: core: Add support for reserved tags Bart Van Assche
2021-11-09 21:09 ` Bart Van Assche
2021-11-10 6:59 ` Hannes Reinecke
2021-11-10 19:19 ` Bart Van Assche
2021-11-11 6:54 ` Hannes Reinecke
2021-11-15 18:46 ` Bart Van Assche
2021-11-17 0:46 ` Bart Van Assche
2021-11-03 0:05 ` [PATCH 2/2] scsi: ufs: Fix a deadlock in the error handler Bart Van Assche
2021-11-03 6:56 ` Adrian Hunter
2021-11-03 13:40 ` Bart Van Assche
2021-11-03 14:03 ` Adrian Hunter
2021-11-07 11:07 ` Avri Altman
2021-11-08 18:26 ` Bart Van Assche
2021-11-03 7:40 ` Christoph Hellwig
2021-11-03 8:37 ` Adrian Hunter
2021-11-03 16:33 ` Christoph Hellwig [this message]
2021-11-03 16:48 ` Bart Van Assche
2021-11-03 13:45 ` Bart Van Assche
2021-11-03 16:27 ` Christoph Hellwig
2021-11-03 16:39 ` Bart Van Assche
2021-11-03 16:41 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYK59D+M5w4FSoo0@infradead.org \
--to=hch@infradead.org \
--cc=adrian.hunter@intel.com \
--cc=asutoshd@codeaurora.org \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=hare@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox