From: Christoph Hellwig <hch@infradead.org>
To: brookxu <brookxu.cn@gmail.com>
Cc: jejb@linux.ibm.com, martin.petersen@oracle.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] scsi: core: use eh_timeout to timeout start_unit command
Date: Tue, 9 Nov 2021 02:03:29 -0800 [thread overview]
Message-ID: <YYpHcRi0TnjSpQqg@infradead.org> (raw)
In-Reply-To: <1636337956-26088-1-git-send-email-brookxu.cn@gmail.com>
On Mon, Nov 08, 2021 at 10:19:16AM +0800, brookxu wrote:
> From: Chunguang Xu <brookxu@tencent.com>
>
> In some abnormal scenarios, STU may timeout. The recovery time
> of 30 seconds is relatively long. Now we need to adjusting
> rq_timeout to adjust STU timeout value, but it will affect the
> actual IO.
>
> ptach 9728c081(make scsi_eh_try_stu use block timeout) uses
> rq_timeout to timeout the STU command, but after pathc 0816c92(
patch is mispelled in two different ways here. But you probably
want to use commit anyway and use 12 charater commit hashes.
> - rtn = scsi_send_eh_cmnd(scmd, stu_command, 6, scmd->device->request_queue->rq_timeout, 0);
> + rtn = scsi_send_eh_cmnd(scmd, stu_command, 6, scmd->device->eh_timeout, 0);
Both the old and new coe is completely unreadable. Please wrap lines
after 80 characters
Otherwise this looks good.
prev parent reply other threads:[~2021-11-09 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 2:19 [RESEND PATCH] scsi: core: use eh_timeout to timeout start_unit command brookxu
2021-11-09 10:03 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YYpHcRi0TnjSpQqg@infradead.org \
--to=hch@infradead.org \
--cc=brookxu.cn@gmail.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox