From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A91DC433FE for ; Tue, 23 Nov 2021 00:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231774AbhKWAUu (ORCPT ); Mon, 22 Nov 2021 19:20:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:48346 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231719AbhKWAUt (ORCPT ); Mon, 22 Nov 2021 19:20:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1637626662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RjMwCURZYhH7uxbsg2k5Wuq2Rys5JGTRvwbIfrl7OJk=; b=c9KGkrPFofzsftDkqHJZiqHdPNRYLr6dkqsgu99+iVNfldr3HT8HKR8uMpgr5CR40inBJe V7Bq8OuEcjFJmZhW+Bxg8bxkVCu0leZ5Aaw9TkhNAq+9YIc5Uc8xQVzGWdVv4v1NMs/DRA TENuXNdemS3Iluu+B8lTHrKF6au2WIQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-6l01jUTYMtefSNGTxcWa8A-1; Mon, 22 Nov 2021 19:17:36 -0500 X-MC-Unique: 6l01jUTYMtefSNGTxcWa8A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 230E8423BA; Tue, 23 Nov 2021 00:17:35 +0000 (UTC) Received: from T590 (ovpn-8-21.pek2.redhat.com [10.72.8.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 565905FC25; Tue, 23 Nov 2021 00:17:24 +0000 (UTC) Date: Tue, 23 Nov 2021 08:17:20 +0800 From: Ming Lei To: Sagi Grimberg Cc: Christoph Hellwig , Jens Axboe , "Martin K . Petersen" , linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, Keith Busch Subject: Re: [PATCH 3/5] blk-mq: add helper of blk_mq_global_quiesce_wait() Message-ID: References: <20211119021849.2259254-1-ming.lei@redhat.com> <20211119021849.2259254-4-ming.lei@redhat.com> <8f6b6452-9abb-fd89-0262-9fb9d00d42a5@grimberg.me> <38b9661e-c5b8-ae18-f2ab-b30f9d3e7115@grimberg.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <38b9661e-c5b8-ae18-f2ab-b30f9d3e7115@grimberg.me> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Mon, Nov 22, 2021 at 03:55:36PM +0200, Sagi Grimberg wrote: > > > > > Add helper of blk_mq_global_quiesce_wait() for supporting to quiesce > > > > queues in parallel, then we can just wait once if global quiesce wait > > > > is allowed. > > > > > > blk_mq_global_quiesce_wait() is a poor name... global is scope-less and > > > obviously it has a scope. > > > > How about blk_mq_shared_quiesce_wait()? or any suggestion? > > Shared between what? All request queues in one host-wide, both scsi and nvme has such requirement. > > Maybe if the queue has a non-blocking tagset, it can have a "quiesced" > flag that is cleared in unquiesce? then the callers can just continue > to iterate but will only wait the rcu grace period once. Yeah, that is what these patches try to implement. Thanks Ming