Re: [PATCH 02/14] scsi: core: Query VPD size before getting full page

Aaron Lauterer
2024-06-05T07:39:07Z

Hi Martin,

thanks for getting back to me.

On 2024-06-05 04:51, Martin K. Petersen wrote:
>
> Aaron,
>
>> The target is an HDD behind a MegaRAID controller configured as JBOD.
>
> Running in JBOD mode is probably part of the problem.
>
>> root@pve1:~# sg_vpd -l /dev/sda
>> Supported VPD pages VPD page:
>> [PQual=0 Peripheral device type: disk]
>> 0x00 Supported VPD pages [sv]
>> 0x80 Unit serial number [sn]
>> 0x83 Device identification [di]
>> 0x87 Mode page policy [mpp]
>> 0x89 ATA information (SAT) [ai]
>> 0x8a Power condition [pc]
>> 0xb0 Block limits (SBC) [bl]
>> 0xb1 Block device characteristics (SBC) [bdc]
>> 0xb2 Logical block provisioning (SBC) [lbpv]
>
> I am working on a fix for what's probably a related issue.
>
> I would appreciate if you could do two things:
>
> 1. Please send me the output of:
>
> # sg_opcodes /dev/sda

Here you go:
---
root@pve1:~# sg_opcodes /dev/sda
ATA HGST HUS726T4TAL W984
Peripheral device type: disk
Report supported operation codes: Illegal request, Invalid opcode
---

I get the same result for the other 2 block devices configured on this
RAID controller. One is another JBOD device (an SSD), the other is a RAID-1.

>
> 2. Try building and booting:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=6.10/scsi-fixes
>
> and see if that makes a difference in your case.

I checked out the 6.10/scsi-fixes branch which was on commit

d53b681 scsi: ufs: mcq: Fix error output and clean up ufshcd_mcq_abort()

to build a new kernel to test.

Unfortunately, I must report that running the `fallocate`[0] command
still works and does not fail with an unsupported error.

If there is more I can do to help, please let me know.

Best regards,
Aaron

[0]
fallocate --punch-hole --keep-size -l 2M /dev/sda --offset 4M