From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C81FC433FE for ; Sat, 23 Apr 2022 15:15:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231725AbiDWPSE (ORCPT ); Sat, 23 Apr 2022 11:18:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44972 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231816AbiDWPRy (ORCPT ); Sat, 23 Apr 2022 11:17:54 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C5AE1D4A46 for ; Sat, 23 Apr 2022 08:14:56 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id 88-20020a9d0ee1000000b005d0ae4e126fso7581621otj.5 for ; Sat, 23 Apr 2022 08:14:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=22eenijkFNhaFMADi9ElotDWSOkFn1tnTr48x0vYVAk=; b=GVdoeLER62JBuMZ1/XSDwKSXWJkTrASzMX5GiiwdNPfJpMt3lNuHKyAGznJg8Jj4YD Y0OgdPH+yHPluQvdKK3tdKlA4FhK00j6P8A+eVTuWE62F0BA+1BT9iPrsiEQhdeB0Lyv Mp55lWoI9zECwZV1oVFZ44zoPfl0NGOMvxjTvQzy57f8uBYv9cxvyEVwOAonr4A0dTy/ FylA5e256esQ4NvjSDMgX+7TWx3tRd5+MhV6m1R/JrsoaVFNS4Zknfl56tfhL248WpNR ORX4eiJMnfEkp8WGVALV2vSEcA9fQNUvChHieI4oGExC8+50/kh7o16ztg8T6y4QK1w/ OjZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=22eenijkFNhaFMADi9ElotDWSOkFn1tnTr48x0vYVAk=; b=PfOG3+EL0BKOlbk3MJpboV9tERUpr8s+C0quwV5vudcbp3klTwbPUxzYG77Yw/8GlL 14Zof1+Uu//+ipoU9u6qaFK+Igp+G5YhCuuFCrXuPRvNSdbubFjfj6D4Y5yH0TH1jHrz 2rNAGcGkczAZ1dE1iowjejq05YRz5Wg+OsAbu9Vuh7IRGPXGKauYybnBRI9WocivEXGX PUE/ZyH4RhNh3ho1yjpd1/fS95SqC5ZwchbJkNgKkGIFkfggmUOq/mwqo5U+sEgwhvBC 52nfOVuEYvzX+bhno25CFcqoflap+cH3ZlcGY4SuqH6YOjBILs8iKCDZoFcBmo22JlGO J+Xg== X-Gm-Message-State: AOAM532DUZVCWC6p5Rvm1O1IkdaTJqbcPLPf/9OXtqwgmkKtCvwelhIb pHZBVqTFsQkFsOrU1g/pczwixA== X-Google-Smtp-Source: ABdhPJyb/SfQ9fd+qfhl32OUbxio3UtCSvHIoOgBXrvsGqMSbnLd4vidbHe+NzwDUCm28o1ezpfXrQ== X-Received: by 2002:a9d:3624:0:b0:5e9:5778:d0c6 with SMTP id w33-20020a9d3624000000b005e95778d0c6mr3657575otb.367.1650726895781; Sat, 23 Apr 2022 08:14:55 -0700 (PDT) Received: from ripper ([2600:1700:a0:3dc8:205:1bff:fec0:b9b3]) by smtp.gmail.com with ESMTPSA id 1-20020a05687011c100b000de98359b43sm1684551oav.1.2022.04.23.08.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 23 Apr 2022 08:14:55 -0700 (PDT) Date: Sat, 23 Apr 2022 08:16:55 -0700 From: Bjorn Andersson To: Manivannan Sadhasivam Cc: martin.petersen@oracle.com, jejb@linux.ibm.com, avri.altman@wdc.com, alim.akhtar@samsung.com, linux-arm-msm@vger.kernel.org, quic_asutoshd@quicinc.com, quic_cang@quicinc.com, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, bvanassche@acm.org, ahalaney@redhat.com Subject: Re: [PATCH v2 2/5] scsi: ufs: qcom: Simplify handling of devm_phy_get() Message-ID: References: <20220423140245.394092-1-manivannan.sadhasivam@linaro.org> <20220423140245.394092-3-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220423140245.394092-3-manivannan.sadhasivam@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Sat 23 Apr 07:02 PDT 2022, Manivannan Sadhasivam wrote: > There is no need to call devm_phy_get() if ACPI is used, so skip it. > The "host->generic_phy" pointer should already be NULL due to the kzalloc, > so no need to set it NULL again. > > Also, don't print the error message in case of -EPROBE_DEFER and return > the error code directly. > > While at it, also remove the comment that has no relationship with > devm_phy_get(). > > Signed-off-by: Manivannan Sadhasivam > --- > drivers/scsi/ufs/ufs-qcom.c | 26 +++++--------------------- > 1 file changed, 5 insertions(+), 21 deletions(-) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > index bee81b45299e..6ee33cc0ad09 100644 > --- a/drivers/scsi/ufs/ufs-qcom.c > +++ b/drivers/scsi/ufs/ufs-qcom.c > @@ -1022,28 +1022,12 @@ static int ufs_qcom_init(struct ufs_hba *hba) > err = 0; > } > > - /* > - * voting/devoting device ref_clk source is time consuming hence > - * skip devoting it during aggressive clock gating. This clock > - * will still be gated off during runtime suspend. > - */ > - host->generic_phy = devm_phy_get(dev, "ufsphy"); > - > - if (host->generic_phy == ERR_PTR(-EPROBE_DEFER)) { > - /* > - * UFS driver might be probed before the phy driver does. > - * In that case we would like to return EPROBE_DEFER code. > - */ > - err = -EPROBE_DEFER; > - dev_warn(dev, "%s: required phy device. hasn't probed yet. err = %d\n", > - __func__, err); > - goto out_variant_clear; > - } else if (IS_ERR(host->generic_phy)) { > - if (has_acpi_companion(dev)) { > - host->generic_phy = NULL; > - } else { > + if (!has_acpi_companion(dev)) { > + host->generic_phy = devm_phy_get(dev, "ufsphy"); > + if (IS_ERR(host->generic_phy)) { > err = PTR_ERR(host->generic_phy); > - dev_err(dev, "%s: PHY get failed %d\n", __func__, err); > + if (err != -EPROBE_DEFER) > + dev_err_probe(dev, err, "Failed to get PHY\n"); I believe the idiomatic form is: err = dev_err_probe(dev, PTR_ERR(host->generic_phy), "Failed to get PHY\n"); But as with the previous patch, please remove the condition and you have my: Reviewed-by: Bjorn Andersson Regards, Bjorn > goto out_variant_clear; > } > } > -- > 2.25.1 >