From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Daniil Lunev <dlunev@chromium.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
Daejun Park <daejun7.park@samsung.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sohaib Mohamed <sohaib.amhmd@gmail.com>,
Stanley Chu <stanley.chu@mediatek.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v2] ufs: core: print capabilities in controller's sysfs node
Date: Fri, 29 Jul 2022 09:20:21 +0200 [thread overview]
Message-ID: <YuOKNX4mWCb1LUrg@kroah.com> (raw)
In-Reply-To: <3f96d798-e9bb-15d8-65b9-2383e112c654@acm.org>
On Thu, Jul 28, 2022 at 04:23:16PM -0700, Bart Van Assche wrote:
> On 7/28/22 16:05, Daniil Lunev wrote:
> > +What: /sys/bus/platform/drivers/ufshcd/*/caps
> > +What: /sys/bus/platform/devices/*.ufs/caps
> > +Date: July 2022
> > +Contact: Daniil Lunev <dlunev@chromium.org>
> > +Description: Read-only attribute. Enabled capabilities of the UFS driver. The
> > + enabled capabilities are determined by what is supported by the
> > + host controller and the UFS device.
> > + Format: 0x%08llx
>
> This documentation is useless since the meaning of the individual bits has
> not been documented.
Yeah, that's not ok, where are these bits coming from and what userspace
tools will be using them?
thanks,
greg k-h
next prev parent reply other threads:[~2022-07-29 7:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 23:05 [PATCH v2] ufs: core: print capabilities in controller's sysfs node Daniil Lunev
2022-07-28 23:23 ` Bart Van Assche
2022-07-29 7:20 ` Greg Kroah-Hartman [this message]
2022-07-29 7:47 ` Daniil Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YuOKNX4mWCb1LUrg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=daejun7.park@samsung.com \
--cc=dlunev@chromium.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+huawei@kernel.org \
--cc=sohaib.amhmd@gmail.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox