From: Eric Biggers <ebiggers@kernel.org>
To: Daniil Lunev <dlunev@chromium.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Bart Van Assche <bvanassche@acm.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Avri Altman <avri.altman@wdc.com>, Bean Huo <beanhuo@micron.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Mauro Carvalho Chehab <mchehab+huawei@kernel.org>,
Sohaib Mohamed <sohaib.amhmd@gmail.com>,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH v6] ufs: core: print UFSHCD capabilities in controller's sysfs node
Date: Wed, 10 Aug 2022 23:19:59 -0700 [thread overview]
Message-ID: <YvSfjwCu69ivTGIZ@sol.localdomain> (raw)
In-Reply-To: <CAONX=-f8kHWCEEyqUdpn5wsyMZKa4eJSSCLvPDn3R5mQF9FSMA@mail.gmail.com>
On Wed, Aug 03, 2022 at 04:34:55PM +1000, Daniil Lunev wrote:
> > > +
> > > +/*
> > > + * The "capabilities" sysfs group represents the effective capabilities of the
> > > + * host-device pair, i.e. the capabilities which are enabled in the driver for
> > > + * the specific host controller, supported by the host controller and are
> > > + * supported and/or have compatible configuration on the device side.
> >
> > Why is this information not also in the Documentation/ABI/ entries as
> > well?
> >
> How would you want me to word it in there? For each entry? There
> will be more in the future, would we need to just copy it as a
> boilerplate? Bart suggested it be added in the code, do you see
> a good way to mention the same in the doc?
> Thanks,
> --Daniil
This is describing the directory, so please include it in a documentation entry
for the directory itself (/sys/bus/platform/drivers/ufshcd/*/capabilities/) just
above the documentation entries for the files in the directory.
- Eric
next prev parent reply other threads:[~2022-08-11 6:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-02 21:50 [PATCH v6] ufs: core: print UFSHCD capabilities in controller's sysfs node Daniil Lunev
2022-08-03 6:12 ` Greg Kroah-Hartman
2022-08-03 6:34 ` Daniil Lunev
2022-08-09 21:16 ` Daniil Lunev
2022-08-10 5:03 ` Greg Kroah-Hartman
2022-08-11 6:19 ` Eric Biggers [this message]
2022-08-11 19:32 ` Daniil Lunev
2022-08-11 19:36 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YvSfjwCu69ivTGIZ@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=dlunev@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mchehab+huawei@kernel.org \
--cc=sohaib.amhmd@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox