From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 534B6C19F2D for ; Thu, 11 Aug 2022 06:20:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbiHKGUF (ORCPT ); Thu, 11 Aug 2022 02:20:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbiHKGUD (ORCPT ); Thu, 11 Aug 2022 02:20:03 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5C13283BE5; Wed, 10 Aug 2022 23:20:02 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D548D6144E; Thu, 11 Aug 2022 06:20:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C86CBC433D6; Thu, 11 Aug 2022 06:20:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1660198801; bh=3UwPeUeQ7VjDnVNZ+LHhCUxVFGX5ZUyFg7qjSB+Mf2U=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NPZw0hIwdfWFx7Nay1KSTarxP3gtJFHt0j/W+VsjS9bqO+LLKEpBAa9J5o+bO799H iiyKae2sAUwRT4YRJvtnQULqmxR+LBOwUE1I42tjJO+4RV0tjBDromCMjPRjWzYfc9 9jDUIr59O/AVdBSdS0wqDJu10mUBumVF2PiSXXSY/LSbmb8St4Wvrh/InyOjh1eItF Q7s2KnEQYf48D3W9RLmyaIoEV9a8qqYdRjA35pMY0AwEdbHuBr6CxQLnwn5c+4OVHv /zD/wYk6ExOMGTXabQWOLZVH3+slWoSwMqVZ03WdjQctE9HtqzmFUNuVZMJ8elzXhp 2hy0Ho/kvnrEQ== Date: Wed, 10 Aug 2022 23:19:59 -0700 From: Eric Biggers To: Daniil Lunev Cc: Greg Kroah-Hartman , Adrian Hunter , Bart Van Assche , Alim Akhtar , Avri Altman , Bean Huo , "James E.J. Bottomley" , "Martin K. Petersen" , Mauro Carvalho Chehab , Sohaib Mohamed , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH v6] ufs: core: print UFSHCD capabilities in controller's sysfs node Message-ID: References: <20220803074955.v6.1.Ibf9efc9be50783eeee55befa2270b7d38552354c@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Aug 03, 2022 at 04:34:55PM +1000, Daniil Lunev wrote: > > > + > > > +/* > > > + * The "capabilities" sysfs group represents the effective capabilities of the > > > + * host-device pair, i.e. the capabilities which are enabled in the driver for > > > + * the specific host controller, supported by the host controller and are > > > + * supported and/or have compatible configuration on the device side. > > > > Why is this information not also in the Documentation/ABI/ entries as > > well? > > > How would you want me to word it in there? For each entry? There > will be more in the future, would we need to just copy it as a > boilerplate? Bart suggested it be added in the code, do you see > a good way to mention the same in the doc? > Thanks, > --Daniil This is describing the directory, so please include it in a documentation entry for the directory itself (/sys/bus/platform/drivers/ufshcd/*/capabilities/) just above the documentation entries for the files in the directory. - Eric