From: Christoph Hellwig <hch@infradead.org>
To: Rik van Riel <riel@surriel.com>
Cc: "Christoph Hellwig" <hch@infradead.org>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Marc Aurèle La France" <tsi@tuyoix.net>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@meta.com
Subject: Re: [PATCH v2] scsi: use GFP_NOIO to avoid circular locking dependency
Date: Thu, 30 Jan 2025 23:10:23 -0800 [thread overview]
Message-ID: <Z5x3XwERjbtL6LDE@infradead.org> (raw)
In-Reply-To: <20250129104525.0ae8421e@fangorn>
On Wed, Jan 29, 2025 at 10:45:25AM -0500, Rik van Riel wrote:
> On Tue, 28 Jan 2025 21:35:18 -0800
> Christoph Hellwig <hch@infradead.org> wrote:
>
> > GFP_NOFS is never the right thing for block layer allocations.
> > The right thing here is GFP_NOIO which is a superset of GFP_NOFS.
> > Otherwise you could reproduce the same deadlock when using swap
> > instead of a file system to reproduce basically the same deadlock.
>
> Duh, you are right of course!
>
> The fixed up patch with GFP_NOIO is below.
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2025-01-31 7:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 21:47 [PATCH] scsi: use GFP_NOFS to avoid circular locking dependency Rik van Riel
2025-01-29 5:35 ` Christoph Hellwig
2025-01-29 15:45 ` [PATCH v2] scsi: use GFP_NOIO " Rik van Riel
2025-01-31 7:10 ` Christoph Hellwig [this message]
2025-02-04 3:33 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z5x3XwERjbtL6LDE@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@hansenpartnership.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=riel@surriel.com \
--cc=tsi@tuyoix.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox