From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11C561C862D for ; Fri, 14 Mar 2025 17:14:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741972460; cv=none; b=NSt9WfTbijG9Hze2bb7dxV4ZQYs/M/cVVqTETjYkzQFzSU8yKuDGZyfXLTs8+5sGkk6gDTW+I+WturpJjXLqZCBUELEdyvMjDN2RQS0SQvMf5MWxM4XCWpfy0aWTr4bd82zKYuw6wlg83JI/KqdXe/UyWmxEAiNvGiVaRD7Szlg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741972460; c=relaxed/simple; bh=5p0iC2SItNuF6AwjE1Hf3HgmLAJx6GZW09MUMx1WDn4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tYU8os3s6ibEezzrHH5iCtcuQxW7Z042N8emyRLsJBT2Bm2Eh+b6On7jN2AEBIejy9Z0wSNvOrs/3WomVpLzuE2ERh9FUQdvE7KMq96RixXUIElnDVJz7QkBME4FPIuO+mTZe3I8VC7rVmHxx7uHjgIjnL8iuz9aAuvfsSq2o8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=UOfIrw7o; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="UOfIrw7o" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-223f4c06e9fso43841525ad.1 for ; Fri, 14 Mar 2025 10:14:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1741972458; x=1742577258; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=yix95Y58aFVDLktEp8lmDmKYUrlcv0lyEDYQZgOfJW0=; b=UOfIrw7oT+4b8yEPf7Mh2zudvDHT7LjYjk4PRUR6nDtvJF0TAUvoBvgiK0Wtqpefy3 K2DeSrNEw5yqYkY/8/Gskgg1juSt3h4RKFgqvxywGTIK3cXUCqeytxE2fwAEq0w+QQZ0 K7UEssTLnlSZeVpuYoIhv/EJnJAs48MpjhUcwjDqxDj4f2uy2qYLPmGIrU3zYlyka04a sj3RPl9mZ5IDgN31WaOCkDmyFBk4mXyDwhyWV0SZyjOgl6k0mpDJ6nAKkVV7f3Zi+Yzh bydkQrtjV6L5+s6tfjUE8X3hr7Os0yPQ12lC9+adIWz1kIFTRqv32C7MPbkjpv+lR8P6 /vNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741972458; x=1742577258; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yix95Y58aFVDLktEp8lmDmKYUrlcv0lyEDYQZgOfJW0=; b=dYH1wcHd/dLGjEsfn1Jwp5v/Ztu5iEYMenxXQXay1IiYRKnjlfk/LfQ/+al8eF1IKL P6asJPIZQ7iGcXYdtAGG7pi24DoVoWdRnQQwki9F7eiEG/XGm/suSLtmr6wCzsS20up6 tdEuO8h2+WwCW8kuJ/aI5BDyzNlKaMJTfFm5Jo6FLdiG16MAFLnjYpFsfxpgj9GTeNyQ 1Qj4AzOfYqeFfVdva9+F7M3jRg4+cYZDlwYs/F7rXWJELBKGA8ozkahlgAzhT6dSaOu2 IgBJK3spXCgp9UMJ0YeiTEidQV3pE3PsaAkzKvGMbUMursLodRBAVq1Qg6guajD6rMRG Mlow== X-Forwarded-Encrypted: i=1; AJvYcCUqCcLu78D3StOhjidS5QdaMy0VwAyv69Gusrx09zn34icO0UMwMOPGXzGQalktY4SUxk3djOwis4fs@vger.kernel.org X-Gm-Message-State: AOJu0Yyl00HimUQb89Fmabjq1fgyDD0PyW2WWGaVfXoi0HBolUVA5vPF OLbg8r+T8OCqgLFnLtFzb6QGrSwO7TKAZuz46Ti6TEJnqv1BM19GynqirlU4uQ== X-Gm-Gg: ASbGnctD+prm8QjohX0D9lclieju5YijXD3zMkXo/789UbR/ZzPKqRolLXfnTryJfXN cbM/SSgjg/ZF0EKTQAQF/B9KSoIyU7ypxbzt/hDKsPNPYQ7cKoUJUaRVNy898hrdDF+2AFv9HvW F/xoq8/sm2Ca66QU4F3P1edrDnzCEAlNaH44ag8t3G6WTVp6EMF33lwY3SyNKnYuel3YIUtvgUv fvUMKjUcsdqLo7qxYCGYZAHmcIdaOEGyXqgjIhO/ZUv7CugBlI4RTGogu1600hgwEXabKS8vvBU p+aW78q8KG6ScvwX2aLwwDa9BuCNc6UFkJZSRIrh4i0jr9qkm3a4yutINbgIC1qyGOA3ajUku0v WEDmNDlka66IshgE= X-Google-Smtp-Source: AGHT+IGy7HWrkPvjUpMMYhRQbw/am4ugxDMqJdGJdWH8dd6X/1N9h09zGNW9ExGPYF3hEaJz1QwaUQ== X-Received: by 2002:a17:902:d4cd:b0:224:3994:8a8c with SMTP id d9443c01a7336-225c6613932mr89268175ad.8.1741972457947; Fri, 14 Mar 2025 10:14:17 -0700 (PDT) Received: from google.com (198.103.247.35.bc.googleusercontent.com. [35.247.103.198]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-225c6bd4d61sm30841415ad.242.2025.03.14.10.14.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Mar 2025 10:14:17 -0700 (PDT) Date: Fri, 14 Mar 2025 10:14:13 -0700 From: William McVicker To: Peter Griffin Cc: =?iso-8859-1?Q?Andr=E9?= Draszik , Tudor Ambarus , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Avri Altman , Bart Van Assche , "Martin K. Petersen" , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH 1/2] arm64: dts: exynos: gs101: ufs: add dma-coherent property Message-ID: References: <20250314-ufs-dma-coherent-v1-0-bdf9f9be2919@linaro.org> <20250314-ufs-dma-coherent-v1-1-bdf9f9be2919@linaro.org> Precedence: bulk X-Mailing-List: linux-scsi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250314-ufs-dma-coherent-v1-1-bdf9f9be2919@linaro.org> On 03/14/2025, Peter Griffin wrote: > ufs-exynos driver configures the sysreg shareability as > cacheable for gs101 so we need to set the dma-coherent > property so the descriptors are also allocated cacheable. > > This fixes the UFS stability issues we have seen with > the upstream UFS driver on gs101. > > Fixes: 4c65d7054b4c ("arm64: dts: exynos: gs101: Add ufs and ufs-phy dt nodes") > Cc: stable@vger.kernel.org > Suggested-by: Will McVicker > Signed-off-by: Peter Griffin Tested-by: Will McVicker Verified I can properly boot to Android recovery with UFS probing and mounting the partitions in the fstab. Can you send this to 6.12 stable as well since this is fixing booting issues with Android? Thanks, Will > --- > arch/arm64/boot/dts/exynos/google/gs101.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > index c5335dd59dfe9fcf8c64d66a466799600f8447b0..cf30128ef004568f01b1c7150c5585ba267d64bc 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi > +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi > @@ -1360,6 +1360,7 @@ ufs_0: ufs@14700000 { > <&cmu_hsi2 CLK_GOUT_HSI2_SYSREG_HSI2_PCLK>; > clock-names = "core_clk", "sclk_unipro_main", "fmp", > "aclk", "pclk", "sysreg"; > + dma-coherent; > freq-table-hz = <0 0>, <0 0>, <0 0>, <0 0>, <0 0>, <0 0>; > pinctrl-0 = <&ufs_rst_n &ufs_refclk_out>; > pinctrl-names = "default"; > > -- > 2.49.0.rc1.451.g8f38331e32-goog >