Re: [RFC PATCH v2 3/7] dt-bindings: mmc: sdhci-msm: Add ICE phandle and drop core clock

Krzysztof Kozlowski
2023-03-09T10:28:24Z

On 08/03/2023 16:58, Abel Vesa wrote:
> The ICE will have its own devicetree node, so drop the ICE core clock
> and add the qcom,ice property instead.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> This patch was not part of the v1.
>
> Documentation/devicetree/bindings/mmc/sdhci-msm.yaml | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> index 64df6919abaf..92f6316c423f 100644
> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.yaml
> @@ -80,7 +80,6 @@ properties:
> - const: iface
> - const: core
> - const: xo
> - - const: ice

Same as for UFS - order is fixed, you cannot drop entries from the middle.

> - const: bus
> - const: cal
> - const: sleep
> @@ -120,6 +119,10 @@ properties:

Best regards,
Krzysztof