Re: [RFC PATCH v2 7/7] arm64: dts: qcom: Add the Inline Crypto Engine nodes

Krzysztof Kozlowski
2023-03-09T10:31:55Z

On 08/03/2023 16:58, Abel Vesa wrote:
> Drop all properties related to ICE from every UFS and SDCC node,
> for all platforms, and add dedicated ICE nodes for each platform.
> On most platforms, there is only one ICE instance, used by either
> UFS or SDCC, but there are some platforms that have two separate
> instances and, therefore, two separate nodes are added.
>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
> ---
>
> Changes since v1:
> * Made changes for all platforms that use ICE, as a single patch since
> most changes look really similar.
>
> arch/arm64/boot/dts/qcom/sdm630.dtsi | 18 +++++++++-----
> arch/arm64/boot/dts/qcom/sdm670.dtsi | 15 +++++++----
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 21 +++++++++-------
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 37 +++++++++++++++++-----------
> arch/arm64/boot/dts/qcom/sm6350.dtsi | 31 ++++++++++++++---------
> arch/arm64/boot/dts/qcom/sm8150.dtsi | 21 +++++++++-------
> arch/arm64/boot/dts/qcom/sm8450.dtsi | 22 ++++++++++-------
> 7 files changed, 102 insertions(+), 63 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm630.dtsi b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> index 5827cda270a0..2aed49104d9d 100644
> --- a/arch/arm64/boot/dts/qcom/sdm630.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm630.dtsi
> @@ -1330,9 +1330,8 @@ opp-200000000 {
> sdhc_1: mmc@c0c4000 {
> compatible = "qcom,sdm630-sdhci", "qcom,sdhci-msm-v5";
> reg = <0x0c0c4000 0x1000>,
> - <0x0c0c5000 0x1000>,
> - <0x0c0c8000 0x8000>;
> - reg-names = "hc", "cqhci", "ice";
> + <0x0c0c5000 0x1000>;
> + reg-names = "hc", "cqhci";

I believe this will break the ICE on these platforms without valid
reason. The commit msg does not explain why you do it or why this is
necessary.

We already we received comment that we keep breaking Qualcomm platforms
all the time and need to keep them in some shape.

Also, patchset is non-applicable in current set (breaks users) and
neither commit nor cover letter mentions it.

Best regards,
Krzysztof