public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Chao Yu <chao@kernel.org>
Cc: martin.petersen@oracle.com, jejb@linux.ibm.com,
	bvanassche@acm.org, hch@infradead.org,
	linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5] scsi: support packing multi-segment in UNMAP command
Date: Fri, 10 Mar 2023 06:02:47 -0800	[thread overview]
Message-ID: <ZAs4h2Mu90u4gc3/@infradead.org> (raw)
In-Reply-To: <20230310123604.1820231-1-chao@kernel.org>

> -	/* If command type is WRITE or DISCARD, set bitmap as dirty */
> -	if (ufshpb_is_write_or_discard(cmd)) {
> +	/* If command type is WRITE, set bitmap as dirty */
> +	if (op_is_write(req_op(scsi_cmd_to_rq(cmd)))) {

Umm, a driver has absolutely no business poking into the UNMAP
payload.   Someone needs to fix the UFS driver first to not do this.

  reply	other threads:[~2023-03-10 14:03 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-10 12:36 [PATCH v5] scsi: support packing multi-segment in UNMAP command Chao Yu
2023-03-10 14:02 ` Christoph Hellwig [this message]
2023-03-13  1:44   ` Chao Yu
2023-03-20 13:00     ` Christoph Hellwig
2023-05-17  3:49 ` Chao Yu
2023-05-22 21:51   ` Martin K. Petersen
2023-06-25  7:07     ` Chao Yu
2023-06-29  2:02       ` Martin K. Petersen
2023-06-29  2:04         ` Chao Yu
2023-07-25  9:19         ` Chao Yu
2023-08-08 13:42         ` Chao Yu
2023-08-08 14:04           ` Martin K. Petersen
2023-08-08 14:12             ` Chao Yu
2023-08-10  2:11               ` Chao Yu
2023-08-22  8:38               ` Chao Yu
2023-10-07 10:13             ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZAs4h2Mu90u4gc3/@infradead.org \
    --to=hch@infradead.org \
    --cc=bvanassche@acm.org \
    --cc=chao@kernel.org \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox