Re: [PATCH] scsi:dc395x: Correct "structures" spelling mistakes

Re: [PATCH] scsi:dc395x: Correct "structures" spelling mistakes

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Fri, May 05, 2023 at 05:41:40PM +0800, Wang Honghui wrote:
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> 
> As title.

1) This is v2 of [1], right? Did you forget to pass `-v` to
   git-format-patch(1)?
2) The trailers (including SoB) should be placed after the patch description.
3) Last but not least, you forget to add my Reviewed-by: from v1 [1].

Please reroll, keeping above in mind.

Thanks.

[1]: https://lore.kernel.org/all/262EBDA8BEEA7619+ZFN1b1D66%2FLp8hzh@TP-P15V/
[2]: https://lore.kernel.org/all/ZFOD%2F6rT36evHXNz@debian.me/

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] scsi:dc395x: Correct "structures" spelling mistakes

[Bagas Sanjaya]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On Fri, May 05, 2023 at 05:41:40PM +0800, Wang Honghui wrote:
> Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>
> 
> As title.
> 
> ---

Another comment: you also didn't write changelog after three dashes above.
Did you forget reading Documentation/process/submitting-patches.rst?

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[PATCH] scsi:dc395x: Correct "structures" spelling mistakes

[Wang Honghui]

Signed-off-by: Wang Honghui <honghui.wang@ucas.com.cn>

As title.

---
 drivers/scsi/dc395x.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c
index c8e86f8a631e..a3f00e6e3296 100644
--- a/drivers/scsi/dc395x.c
+++ b/drivers/scsi/dc395x.c
@@ -3641,7 +3641,7 @@ static void adapter_add_device(struct AdapterCtlBlk *acb,
  * adapter_remove_device - Removes the device instance from the adaptor
  * instance. The device instance is not check in any way or freed by this. 
  * The caller is expected to take care of that. This will simply remove the
- * device from the adapters data strcutures.
+ * device from the adapters data structures.
  *
  * @acb: The adapter device to be updated
  * @dcb: A device that has previously been added to the adapter.
@@ -3980,7 +3980,7 @@ static void trms1040_read_all(struct NvRamType *eeprom, unsigned long io_port)
  * Checks the checksum and if it's not correct it uses a set of default
  * values.
  *
- * @eeprom:	caller allocated strcuture to read the eeprom data into
+ * @eeprom:	caller allocated structure to read the eeprom data into
  * @io_port:	io port to read from
  **/
 static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port)
@@ -4578,7 +4578,7 @@ static void banner_display(void)
  * dc395x_init_one - Initialise a single instance of the adapter.
  *
  * The PCI layer will call this once for each instance of the adapter
- * that it finds in the system. The pci_dev strcuture indicates which
+ * that it finds in the system. The pci_dev structure indicates which
  * instance we are being called from.
  * 
  * @dev: The PCI device to initialize.
-- 
2.34.1