From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>
Subject: Re: [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment
Date: Wed, 24 May 2023 08:03:09 +0000 [thread overview]
Message-ID: <ZG3EuV0/cwYhYUt2@x1-carbon> (raw)
In-Reply-To: <20230523074701.293502-1-dlemoal@kernel.org>
On Tue, May 23, 2023 at 04:47:01PM +0900, Damien Le Moal wrote:
> Add missing description of the spg argument of ata_msense_control().
>
> Fixes: df60f9c64576 ("scsi: ata: libata: Add ATA feature control sub-page translation")
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> ---
> drivers/ata/libata-scsi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
> index 69fc0d2c2123..40d6703e2d07 100644
> --- a/drivers/ata/libata-scsi.c
> +++ b/drivers/ata/libata-scsi.c
> @@ -3850,6 +3850,7 @@ static unsigned int ata_mselect_control_ata_feature(struct ata_queued_cmd *qc,
> /**
> * ata_mselect_control - Simulate MODE SELECT for control page
> * @qc: Storage for translated ATA taskfile
> + * @spg: target sub-page of the control page
> * @buf: input buffer
> * @len: number of valid bytes in the input buffer
> * @fp: out parameter for the failed field on error
> --
> 2.40.1
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2023-05-24 8:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 7:47 [PATCH] ata: libata-scsi: fix ata_msense_control kdoc comment Damien Le Moal
2023-05-23 9:17 ` Johannes Thumshirn
2023-05-24 8:03 ` Niklas Cassel [this message]
2023-05-31 15:21 ` Martin K. Petersen
2023-06-08 1:42 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZG3EuV0/cwYhYUt2@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=dlemoal@kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox