From: Konstantin Shelekhin <k.shelekhin@yadro.com>
To: Mike Christie <michael.christie@oracle.com>
Cc: Martin Petersen <martin.petersen@oracle.com>,
<target-devel@vger.kernel.org>, <linux-scsi@vger.kernel.org>,
<linux@yadro.com>, Dmitry Bogdanov <d.bogdanov@yadro.com>
Subject: Re: [PATCH 2/2] scsi: target: iblock: Report space allocation errors
Date: Sun, 21 May 2023 21:28:06 +0300 [thread overview]
Message-ID: <ZGpitkN0tMJeOA-8@yadro.com> (raw)
In-Reply-To: <80a07968-e33f-efba-cd7a-6e3047a520c4@oracle.com>
On Sat, May 20, 2023 at 01:05:01PM -0500, Mike Christie wrote:
> On 5/17/23 9:15 AM, Konstantin Shelekhin wrote:
> > When a thin provisioned block device lacks free LBA it ends bio requests
> > with BLK_STS_NOSPC. Currently iblock treats bio status as a boolean and
> > terminates failed requests with LOGICAL UNIT COMMUNICATION FAILURE if
> > the status is non-zero. Thus, initiators see space allocation errors as
> > I/O errors.
> >
> > This commit modifies the iblock_req structure to store the status of the
> > first failed bio instead of the total number of failed bios. The status
> > is then used to set the specific sense reason.
> >
>
> You posted this patch before right? I think it didn't get picked up because
> the kernel bot keeps flagging the mixing of the blk_status_t and atomic_t.
> Just build with sparse C=1 and you should see it.
Dammit, I thought I fixed this the last time. Will fix and resend.
next prev parent reply other threads:[~2023-05-21 18:29 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 14:15 [PATCH 0/2] scsi: target: iblock: Report space allocation errors Konstantin Shelekhin
2023-05-17 14:15 ` [PATCH 1/2] scsi: target: core: Add sense reason for " Konstantin Shelekhin
2023-05-17 14:15 ` [PATCH 2/2] scsi: target: iblock: Report " Konstantin Shelekhin
2023-05-19 18:05 ` kernel test robot
2023-05-20 18:05 ` Mike Christie
2023-05-21 18:28 ` Konstantin Shelekhin [this message]
2023-05-27 19:50 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2021-10-20 18:43 [PATCH 0/2] " Konstantin Shelekhin
2021-10-20 18:43 ` [PATCH 2/2] " Konstantin Shelekhin
2021-10-22 5:27 ` kernel test robot
2021-11-08 9:59 ` kernel test robot
2021-11-23 13:29 ` kernel test robot
2021-11-25 2:36 ` kernel test robot
2021-11-25 7:26 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGpitkN0tMJeOA-8@yadro.com \
--to=k.shelekhin@yadro.com \
--cc=d.bogdanov@yadro.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@yadro.com \
--cc=martin.petersen@oracle.com \
--cc=michael.christie@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox