From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Damien Le Moal <dlemoal@kernel.org>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH] block: improve ioprio value validity checks
Date: Wed, 7 Jun 2023 15:16:54 +0000 [thread overview]
Message-ID: <ZICfY7ssJ2qoxNnc@x1-carbon> (raw)
In-Reply-To: <CACRpkdZskZ-GktsYL0MXbMwdOQmF=-4yyns3u+-2eHP1Nt_RHg@mail.gmail.com>
On Tue, May 30, 2023 at 01:30:18PM +0200, Linus Walleij wrote:
> On Tue, May 30, 2023 at 11:09 AM Niklas Cassel <Niklas.Cassel@wdc.com> wrote:
>
> > The fix that Damien suggested, which adds multiple boundary checks in the
> > IOPRIO_PRIO_VALUE() macro will fix any user space program that uses the uapi
> > header.
>
> Fixing things in the UAPI headers make it easier to do things right
> going forward with classes and all.
Hello Linus,
Thank you for providing your input!
Considering that you seem to be in favor of fixing things in the UAPI
headers (i.e. the patch in $subject).
Could you possibly consider sending a proper A-b or R-b tag?
Kind regards,
Niklas
next prev parent reply other threads:[~2023-06-07 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 6:13 [PATCH] block: improve ioprio value validity checks Damien Le Moal
2023-05-30 9:08 ` Niklas Cassel
2023-05-30 11:30 ` Linus Walleij
2023-05-31 4:54 ` Damien Le Moal
2023-06-05 4:43 ` Damien Le Moal
2023-06-07 15:16 ` Niklas Cassel [this message]
2023-06-07 15:00 ` Niklas Cassel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZICfY7ssJ2qoxNnc@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=axboe@kernel.dk \
--cc=dlemoal@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox