From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
Luis Chamberlain <mcgrof@kernel.org>
Subject: Re: [PATCH] scsi: sd_zbc: use PAGE_SECTORS_SHIFT
Date: Tue, 13 Jun 2023 12:52:47 +0000 [thread overview]
Message-ID: <ZIhmmGmVdavs7B5D@x1-carbon> (raw)
In-Reply-To: <20230613-sd_zbc-page_sectors-v1-1-363460a4413d@wdc.com>
On Tue, Jun 13, 2023 at 05:31:45AM -0700, Johannes Thumshirn wrote:
> Use PAGE_SECTORS_SHIFT instead of open-coding it.
>
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> ---
> drivers/scsi/sd_zbc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c
> index 22801c24ea19..abbd08933ac7 100644
> --- a/drivers/scsi/sd_zbc.c
> +++ b/drivers/scsi/sd_zbc.c
> @@ -889,7 +889,7 @@ int sd_zbc_revalidate_zones(struct scsi_disk *sdkp)
> }
>
> max_append = min_t(u32, logical_to_sectors(sdkp->device, zone_blocks),
> - q->limits.max_segments << (PAGE_SHIFT - 9));
> + q->limits.max_segments << PAGE_SECTORS_SHIFT);
> max_append = min_t(u32, max_append, queue_max_hw_sectors(q));
>
> blk_queue_max_zone_append_sectors(q, max_append);
>
> ---
> base-commit: 467e6cc73ef290f0099b1b86cec4f14060984916
> change-id: 20230613-sd_zbc-page_sectors-f462501f7ab4
>
> Best regards,
> --
> Johannes Thumshirn <johannes.thumshirn@wdc.com>
>
Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
next prev parent reply other threads:[~2023-06-13 12:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-13 12:31 [PATCH] scsi: sd_zbc: use PAGE_SECTORS_SHIFT Johannes Thumshirn
2023-06-13 12:52 ` Niklas Cassel [this message]
2023-06-15 1:52 ` Martin K. Petersen
2023-06-22 1:26 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIhmmGmVdavs7B5D@x1-carbon \
--to=niklas.cassel@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox